Opinionated OCaml linter with Merlin integration for code quality, naming conventions, and style checks
fix(lint): resolve E410, E415, E605 in irmin; tidy irmin bin/lib
- E605: Split monolithic test_irmin.ml into 10 per-module test files
(test_hash, test_tree, test_backend, test_store, test_codec, test_link,
test_proof, test_commit, test_git_interop, test_subtree)
- E410: Fix doc arg count for any_algorithm, any_to_bytes, any_to_hex
- E415: Add Proof.pp pretty-printer
- Tidy irmin bin commands (cmd_checkout, cmd_import, cmd_info)
- Tidy irmin lib (backend, codec, link) and add irmin.mli
- Fix merlint E331 rule, dune fmt across space-dtn
+4
-14
+4
-14
lib/rules/e331.ml
+4
-14
lib/rules/e331.ml
···
59
59
else None
60
60
in
61
61
62
-
(* Collect all value names to detect clashes *)
63
-
let existing_names =
64
-
List.filter_map
65
-
(fun (item : Outline.item) ->
66
-
match item.kind with Outline.Value -> Some item.name | _ -> None)
67
-
outline_data
68
-
in
69
-
70
62
List.filter_map
71
63
(fun (item : Outline.item) ->
72
64
let name = item.name in
···
76
68
| Outline.Value, Some loc -> (
77
69
(* Check for regular function prefix patterns *)
78
70
match check_function_prefix name with
79
-
| Some (prefix_type, suggested)
80
-
when not (List.mem suggested existing_names) ->
71
+
| Some (prefix_type, suggested) ->
81
72
Some
82
73
(Issue.v ~loc
83
74
{
···
86
77
prefix_type;
87
78
context = name;
88
79
})
89
-
| Some _ | None -> (
80
+
| None -> (
90
81
(* Check for Module.create_module pattern *)
91
82
match check_module_create_prefix name with
92
-
| Some (prefix_type, suggested)
93
-
when not (List.mem suggested existing_names) ->
83
+
| Some (prefix_type, suggested) ->
94
84
Some
95
85
(Issue.v ~loc
96
86
{
···
100
90
context =
101
91
String.capitalize_ascii module_name ^ "." ^ name;
102
92
})
103
-
| Some _ | None -> None))
93
+
| None -> None))
104
94
| _ -> None)
105
95
outline_data
106
96