malpercio.dev / ezpds
An easy-to-host PDS on the ATProtocol, iPhone and MacOS. Maintain control of your keys and data, always.
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

fix: remove MM-146.AC* ticket references from test comments

Removes 6 test comment lines with MM-146.AC* ticket/AC references that
violate CLAUDE.md convention: "No ticket or AC references in source code."

Test function names are self-documenting:
- get_relay_keys_returns_503_when_no_key_provisioned (AC1.3)
- get_relay_keys_returns_200_with_active_key (AC1.1)
- get_relay_keys_returns_most_recently_created_key (AC1.2)
- get_relay_keys_requires_no_authentication (AC1.4)
- external_signer_callback_produces_valid_genesis_op (AC2.1)
- external_signer_callback_error_propagates_as_plc_operation (AC2.2)

Files changed:
- crates/relay/src/routes/get_relay_signing_key.rs: lines 91, 98, 116, 135
- crates/crypto/src/plc.rs: lines 776, 808

Tests: All tests pass (relay get_relay: 4/4, crypto: 44/44)
Formatting: cargo fmt --all --check passes

authored by

Malpercio and committed by
Tangled f66b1ab0 f8ba74cb

-6
-2
crates/crypto/src/plc.rs
··· 773 773 ); 774 774 } 775 775 776 - // MM-146.AC2.1: Callback receives CBOR bytes; returned PlcGenesisOp passes verify_genesis_op. 777 776 #[test] 778 777 fn external_signer_callback_produces_valid_genesis_op() { 779 778 let rotation_kp = generate_p256_keypair().expect("rotation keypair"); ··· 805 804 ); 806 805 } 807 806 808 - // MM-146.AC2.2: Callback returning Err propagates as CryptoError::PlcOperation. 809 807 #[test] 810 808 fn external_signer_callback_error_propagates_as_plc_operation() { 811 809 let rotation_kp = generate_p256_keypair().expect("rotation keypair");
-4
crates/relay/src/routes/get_relay_signing_key.rs
··· 88 88 .unwrap() 89 89 } 90 90 91 - // MM-146.AC1.3: Returns 503 when no signing key is provisioned. 92 91 #[tokio::test] 93 92 async fn get_relay_keys_returns_503_when_no_key_provisioned() { 94 93 let response = app(test_state().await).oneshot(get_keys()).await.unwrap(); 95 94 assert_eq!(response.status(), StatusCode::SERVICE_UNAVAILABLE); 96 95 } 97 96 98 - // MM-146.AC1.1: Returns 200 with { keyId, publicKey, algorithm } when a key is provisioned. 99 97 #[tokio::test] 100 98 async fn get_relay_keys_returns_200_with_active_key() { 101 99 let state = test_state().await; ··· 113 111 assert!(json["publicKey"].is_string(), "publicKey must be present"); 114 112 } 115 113 116 - // MM-146.AC1.2: Returns the most recently created key when multiple keys exist. 117 114 #[tokio::test] 118 115 async fn get_relay_keys_returns_most_recently_created_key() { 119 116 let state = test_state().await; ··· 132 129 ); 133 130 } 134 131 135 - // MM-146.AC1.4: Endpoint requires no authentication. 136 132 #[tokio::test] 137 133 async fn get_relay_keys_requires_no_authentication() { 138 134 // test_state() has no admin_token configured.