The open source OpenXR runtime
a/vk: Disable naming of VkSurfaceKHR objects
Causes crashes and asserts on Ubuntu 22.04 Mesa.
+5
-1
+5
-1
src/xrt/auxiliary/vk/vk_helpers.h
+5
-1
src/xrt/auxiliary/vk/vk_helpers.h
···
651
651
*
652
652
* 1. Both Mesa and the Vulkan loader didn't support setting names on the
653
653
* VkInstance, loader got support in 1.3.261 and Mesa hasn't as of writing.
654
+
* 2. For Mesa drivers we can not name VkSurfaceKHR objects on some systems as
655
+
* it causes memory corruption, asserts, crashes or functions failing. This
656
+
* is as of writing broken on the 23.2.1 release, fixed in main and scheduled
657
+
* for the 23.2.2 release.
654
658
*
655
659
* @ingroup aux_vk
656
660
*/
···
687
691
#define VK_NAME_FRAMEBUFFER(VK, OBJ, NAME) VK_NAME_OBJ(VK, VkFramebuffer, FRAMEBUFFER, OBJ, NAME)
688
692
#define VK_NAME_COMMAND_POOL(VK, OBJ, NAME) VK_NAME_OBJ(VK, VkCommandPool, COMMAND_POOL, OBJ, NAME)
689
693
690
-
#define VK_NAME_SURFACE(VK, OBJ, NAME) VK_NAME_OBJ(VK, VkSurfaceKHR, SURFACE_KHR, OBJ, NAME)
694
+
#define VK_NAME_SURFACE(VK, OBJ, NAME) VK_NAME_OBJ_DISABLED(VK, VkSurfaceKHR, OBJ)
691
695
#define VK_NAME_SWAPCHAIN(VK, OBJ, NAME) VK_NAME_OBJ(VK, VkSwapchainKHR, SWAPCHAIN_KHR, OBJ, NAME)
692
696
// clang-format on
693
697