-8

bin/tests/data/manual_inherit_from.nix

reviewed

··· 1 1 - let 2 2 - a = {b = 2; c = 3;}; 3 3 - in 4 4 - { 5 5 - b = a.b; 6 6 - c = a.c; 7 7 - } 8 8 -

-1

bin/tests/main.rs

reviewed

··· 44 44 } 45 45 46 46 test_lint! { 47 47 - manual_inherit_from, 48 47 legacy_let_syntax, 49 48 collapsible_let_in, 50 49 eta_reduction,

+12

bin/tests/manual_inherit_from.rs

reviewed

··· 1 1 + mod _utils; 2 2 + 3 3 + use macros::generate_tests; 4 4 + 5 5 + generate_tests! { 6 6 + rule: manual_inherit, 7 7 + expressions: [ 8 8 + "let a.b = 2; in { b = a.b; }", 9 9 + "let a.b = 2; in { c = a.c; }", 10 10 + "let a.b = 2; in { b = a.c; }", 11 11 + ], 12 12 + }

-16

bin/tests/snapshots/main__manual_inherit_from_fix.snap

reviewed

··· 1 1 - --- 2 2 - source: bin/tests/main.rs 3 3 - expression: "&stdout" 4 4 - --- 5 5 - --- tests/data/manual_inherit_from.nix 6 6 - +++ tests/data/manual_inherit_from.nix [fixed] 7 7 - @@ -1,8 +1,8 @@ 8 8 - let 9 9 - a = {b = 2; c = 3;}; 10 10 - in 11 11 - { 12 12 - - b = a.b; 13 13 - - c = a.c; 14 14 - + inherit (a) b; 15 15 - + inherit (a) c; 16 16 - }

-18

bin/tests/snapshots/main__manual_inherit_from_lint.snap

reviewed

··· 1 1 - --- 2 2 - source: bin/tests/main.rs 3 3 - expression: "&stdout" 4 4 - --- 5 5 - [W04] Warning: Assignment instead of inherit from 6 6 - ╭─[tests/data/manual_inherit_from.nix:5:3] 7 7 - │ 8 8 - 5 │ b = a.b; 9 9 - · ────┬─── 10 10 - · ╰───── This assignment is better written with inherit 11 11 - ───╯ 12 12 - [W04] Warning: Assignment instead of inherit from 13 13 - ╭─[tests/data/manual_inherit_from.nix:6:3] 14 14 - │ 15 15 - 6 │ c = a.c; 16 16 - · ────┬─── 17 17 - · ╰───── This assignment is better written with inherit 18 18 - ───╯

+5

bin/tests/snapshots/manual_inherit_from__fix_a1dd16d76c1e3a76c0da83256a89a945dccc51f490fd14269722a647f8cda9ad.snap

reviewed

··· 1 1 + --- 2 2 + source: bin/tests/manual_inherit_from.rs 3 3 + expression: "\"let a.b = 2; in { b = a.c; }\"" 4 4 + --- 5 5 +

+9

bin/tests/snapshots/manual_inherit_from__fix_d185f6bcc057384cb2f1ae3abb567fd17572eaaa2c3209abd0f527f3fe7e26a1.snap

reviewed

··· 1 1 + --- 2 2 + source: bin/tests/manual_inherit_from.rs 3 3 + expression: "\"let a.b = 2; in { b = a.b; }\"" 4 4 + --- 5 5 + --- <temp_file_path> 6 6 + +++ <temp_file_path> [fixed] 7 7 + @@ -1 +1 @@ 8 8 + -let a.b = 2; in { b = a.b; } 9 9 + +let a.b = 2; in { inherit (a) b; }

+9

bin/tests/snapshots/manual_inherit_from__fix_fddffc3b779f8727d3ce7613925d3d3df2bc6cc9a30841fe104e26219ed72187.snap

reviewed

··· 1 1 + --- 2 2 + source: bin/tests/manual_inherit_from.rs 3 3 + expression: "\"let a.b = 2; in { c = a.c; }\"" 4 4 + --- 5 5 + --- <temp_file_path> 6 6 + +++ <temp_file_path> [fixed] 7 7 + @@ -1 +1 @@ 8 8 + -let a.b = 2; in { c = a.c; } 9 9 + +let a.b = 2; in { inherit (a) c; }

+5

bin/tests/snapshots/manual_inherit_from__lint_a1dd16d76c1e3a76c0da83256a89a945dccc51f490fd14269722a647f8cda9ad.snap

reviewed

··· 1 1 + --- 2 2 + source: bin/tests/manual_inherit_from.rs 3 3 + expression: "\"let a.b = 2; in { b = a.c; }\"" 4 4 + --- 5 5 +

+11

bin/tests/snapshots/manual_inherit_from__lint_d185f6bcc057384cb2f1ae3abb567fd17572eaaa2c3209abd0f527f3fe7e26a1.snap

reviewed

··· 1 1 + --- 2 2 + source: bin/tests/manual_inherit_from.rs 3 3 + expression: "\"let a.b = 2; in { b = a.b; }\"" 4 4 + --- 5 5 + [W04] Warning: Assignment instead of inherit from 6 6 + ╭─[<temp_file_path>:1:19] 7 7 + │ 8 8 + 1 │ let a.b = 2; in { b = a.b; } 9 9 + · ────┬─── 10 10 + · ╰───── This assignment is better written with inherit 11 11 + ───╯

+11

bin/tests/snapshots/manual_inherit_from__lint_fddffc3b779f8727d3ce7613925d3d3df2bc6cc9a30841fe104e26219ed72187.snap

reviewed

··· 1 1 + --- 2 2 + source: bin/tests/manual_inherit_from.rs 3 3 + expression: "\"let a.b = 2; in { c = a.c; }\"" 4 4 + --- 5 5 + [W04] Warning: Assignment instead of inherit from 6 6 + ╭─[<temp_file_path>:1:19] 7 7 + │ 8 8 + 1 │ let a.b = 2; in { c = a.c; } 9 9 + · ────┬─── 10 10 + · ╰───── This assignment is better written with inherit 11 11 + ───╯