+2 -2

src/applications/audit/storage/PhabricatorAuditTransaction.php

reviewed

··· 258 258 return parent::getTitle(); 259 259 } 260 260 261 261 - public function getTitleForFeed(PhabricatorFeedStory $story) { 261 261 + public function getTitleForFeed() { 262 262 $old = $this->getOldValue(); 263 263 $new = $this->getNewValue(); 264 264 ··· 375 375 376 376 } 377 377 378 378 - return parent::getTitleForFeed($story); 378 378 + return parent::getTitleForFeed(); 379 379 } 380 380 381 381 public function getBodyForFeed(PhabricatorFeedStory $story) {

+1 -1

src/applications/config/storage/PhabricatorConfigTransaction.php

reviewed

··· 55 55 return parent::getTitle(); 56 56 } 57 57 58 58 - public function getTitleForFeed(PhabricatorFeedStory $story = null) { 58 58 + public function getTitleForFeed() { 59 59 $author_phid = $this->getAuthorPHID(); 60 60 61 61 $old = $this->getOldValue();

+2 -2

src/applications/dashboard/storage/PhabricatorDashboardPanelTransaction.php

reviewed

··· 52 52 return parent::getTitle(); 53 53 } 54 54 55 55 - public function getTitleForFeed(PhabricatorFeedStory $story) { 55 55 + public function getTitleForFeed() { 56 56 $author_phid = $this->getAuthorPHID(); 57 57 $object_phid = $this->getObjectPHID(); 58 58 ··· 92 92 } 93 93 } 94 94 95 95 - return parent::getTitleForFeed($story); 95 95 + return parent::getTitleForFeed(); 96 96 } 97 97 98 98 public function getColor() {

+2 -2

src/applications/dashboard/storage/PhabricatorDashboardTransaction.php

reviewed

··· 42 42 return parent::getTitle(); 43 43 } 44 44 45 45 - public function getTitleForFeed(PhabricatorFeedStory $story) { 45 45 + public function getTitleForFeed() { 46 46 $author_phid = $this->getAuthorPHID(); 47 47 $object_phid = $this->getObjectPHID(); 48 48 ··· 70 70 } 71 71 } 72 72 73 73 - return parent::getTitleForFeed($story); 73 73 + return parent::getTitleForFeed(); 74 74 } 75 75 76 76 public function getColor() {

+1 -2

src/applications/differential/customfield/DifferentialBlameRevisionField.php

reviewed

··· 74 74 } 75 75 76 76 public function getApplicationTransactionTitleForFeed( 77 77 - PhabricatorApplicationTransaction $xaction, 78 78 - PhabricatorFeedStory $story) { 77 77 + PhabricatorApplicationTransaction $xaction) { 79 78 80 79 $object_phid = $xaction->getObjectPHID(); 81 80 $author_phid = $xaction->getAuthorPHID();

+1 -2

src/applications/differential/customfield/DifferentialRepositoryField.php

reviewed

··· 99 99 } 100 100 101 101 public function getApplicationTransactionTitleForFeed( 102 102 - PhabricatorApplicationTransaction $xaction, 103 103 - PhabricatorFeedStory $story) { 102 102 + PhabricatorApplicationTransaction $xaction) { 104 103 105 104 $object_phid = $xaction->getObjectPHID(); 106 105 $author_phid = $xaction->getAuthorPHID();

+1 -2

src/applications/differential/customfield/DifferentialRevertPlanField.php

reviewed

··· 103 103 } 104 104 105 105 public function getApplicationTransactionTitleForFeed( 106 106 - PhabricatorApplicationTransaction $xaction, 107 107 - PhabricatorFeedStory $story) { 106 106 + PhabricatorApplicationTransaction $xaction) { 108 107 109 108 $object_phid = $xaction->getObjectPHID(); 110 109 $author_phid = $xaction->getAuthorPHID();

+1 -2

src/applications/differential/customfield/DifferentialSummaryField.php

reviewed

··· 58 58 } 59 59 60 60 public function getApplicationTransactionTitleForFeed( 61 61 - PhabricatorApplicationTransaction $xaction, 62 62 - PhabricatorFeedStory $story) { 61 61 + PhabricatorApplicationTransaction $xaction) { 63 62 64 63 $object_phid = $xaction->getObjectPHID(); 65 64 $author_phid = $xaction->getAuthorPHID();

+1 -2

src/applications/differential/customfield/DifferentialTestPlanField.php

reviewed

··· 72 72 } 73 73 74 74 public function getApplicationTransactionTitleForFeed( 75 75 - PhabricatorApplicationTransaction $xaction, 76 76 - PhabricatorFeedStory $story) { 75 75 + PhabricatorApplicationTransaction $xaction) { 77 76 78 77 $object_phid = $xaction->getObjectPHID(); 79 78 $author_phid = $xaction->getAuthorPHID();

+1 -2

src/applications/differential/customfield/DifferentialTitleField.php

reviewed

··· 75 75 } 76 76 77 77 public function getApplicationTransactionTitleForFeed( 78 78 - PhabricatorApplicationTransaction $xaction, 79 79 - PhabricatorFeedStory $story) { 78 78 + PhabricatorApplicationTransaction $xaction) { 80 79 81 80 $object_phid = $xaction->getObjectPHID(); 82 81 $author_phid = $xaction->getAuthorPHID();

+2 -2

src/applications/differential/storage/DifferentialTransaction.php

reviewed

··· 326 326 return parent::renderExtraInformationLink(); 327 327 } 328 328 329 329 - public function getTitleForFeed(PhabricatorFeedStory $story) { 329 329 + public function getTitleForFeed() { 330 330 $author_phid = $this->getAuthorPHID(); 331 331 $object_phid = $this->getObjectPHID(); 332 332 ··· 452 452 } 453 453 } 454 454 455 455 - return parent::getTitleForFeed($story); 455 455 + return parent::getTitleForFeed(); 456 456 } 457 457 458 458 public function getIcon() {

+2 -2

src/applications/fund/storage/FundInitiativeTransaction.php

reviewed

··· 133 133 return parent::getTitle(); 134 134 } 135 135 136 136 - public function getTitleForFeed(PhabricatorFeedStory $story) { 136 136 + public function getTitleForFeed() { 137 137 $author_phid = $this->getAuthorPHID(); 138 138 $object_phid = $this->getObjectPHID(); 139 139 ··· 197 197 $this->renderHandleLink($object_phid)); 198 198 } 199 199 200 200 - return parent::getTitleForFeed($story); 200 200 + return parent::getTitleForFeed(); 201 201 } 202 202 203 203 public function getMailTags() {

+2 -2

src/applications/macro/storage/PhabricatorMacroTransaction.php

reviewed

··· 124 124 return parent::getTitle(); 125 125 } 126 126 127 127 - public function getTitleForFeed(PhabricatorFeedStory $story) { 127 127 + public function getTitleForFeed() { 128 128 $author_phid = $this->getAuthorPHID(); 129 129 $object_phid = $this->getObjectPHID(); 130 130 ··· 201 201 202 202 } 203 203 204 204 - return parent::getTitleForFeed($story); 204 204 + return parent::getTitleForFeed(); 205 205 } 206 206 207 207 public function getActionName() {

+3 -3

src/applications/maniphest/storage/ManiphestTransaction.php

reviewed

··· 554 554 return parent::getTitle(); 555 555 } 556 556 557 557 - public function getTitleForFeed(PhabricatorFeedStory $story) { 557 557 + public function getTitleForFeed() { 558 558 $author_phid = $this->getAuthorPHID(); 559 559 $object_phid = $this->getObjectPHID(); 560 560 ··· 711 711 // code in the parent; 712 712 $clone = clone $this; 713 713 $clone->setTransactionType(PhabricatorTransactions::TYPE_EDGE); 714 714 - return $clone->getTitleForFeed($story); 714 714 + return $clone->getTitleForFeed(); 715 715 716 716 case self::TYPE_ATTACH: 717 717 $old = nonempty($old, array()); ··· 773 773 774 774 } 775 775 776 776 - return parent::getTitleForFeed($story); 776 776 + return parent::getTitleForFeed(); 777 777 } 778 778 779 779 public function hasChangeDetails() {

+2 -2

src/applications/paste/storage/PhabricatorPasteTransaction.php

reviewed

··· 90 90 return parent::getTitle(); 91 91 } 92 92 93 93 - public function getTitleForFeed(PhabricatorFeedStory $story) { 93 93 + public function getTitleForFeed() { 94 94 $author_phid = $this->getAuthorPHID(); 95 95 $object_phid = $this->getObjectPHID(); 96 96 ··· 126 126 break; 127 127 } 128 128 129 129 - return parent::getTitleForFeed($story); 129 129 + return parent::getTitleForFeed(); 130 130 } 131 131 132 132 public function getColor() {

+2 -2

src/applications/pholio/storage/PholioTransaction.php

reviewed

··· 209 209 return parent::getTitle(); 210 210 } 211 211 212 212 - public function getTitleForFeed(PhabricatorFeedStory $story) { 212 212 + public function getTitleForFeed() { 213 213 $author_phid = $this->getAuthorPHID(); 214 214 $object_phid = $this->getObjectPHID(); 215 215 ··· 278 278 break; 279 279 } 280 280 281 281 - return parent::getTitleForFeed($story); 281 281 + return parent::getTitleForFeed(); 282 282 } 283 283 284 284 public function getBodyForFeed(PhabricatorFeedStory $story) {

+2 -2

src/applications/phriction/storage/PhrictionTransaction.php

reviewed

··· 214 214 return parent::getTitle(); 215 215 } 216 216 217 217 - public function getTitleForFeed(PhabricatorFeedStory $story) { 217 217 + public function getTitleForFeed() { 218 218 $author_phid = $this->getAuthorPHID(); 219 219 $object_phid = $this->getObjectPHID(); 220 220 ··· 250 250 $this->renderHandleLink($object_phid)); 251 251 252 252 } 253 253 - return parent::getTitleForFeed($story); 253 253 + return parent::getTitleForFeed(); 254 254 } 255 255 256 256 public function hasChangeDetails() {

+2 -2

src/applications/ponder/storage/PonderAnswerTransaction.php

reviewed

··· 60 60 return parent::getTitle(); 61 61 } 62 62 63 63 - public function getTitleForFeed(PhabricatorFeedStory $story) { 63 63 + public function getTitleForFeed() { 64 64 $author_phid = $this->getAuthorPHID(); 65 65 $object_phid = $this->getObjectPHID(); 66 66 ··· 72 72 $this->renderHandleLink($object_phid)); 73 73 } 74 74 75 75 - return parent::getTitleForFeed($story); 75 75 + return parent::getTitleForFeed(); 76 76 } 77 77 78 78 public function getBodyForFeed(PhabricatorFeedStory $story) {

+2 -2

src/applications/ponder/storage/PonderQuestionTransaction.php

reviewed

··· 202 202 return parent::shouldHide(); 203 203 } 204 204 205 205 - public function getTitleForFeed(PhabricatorFeedStory $story) { 205 205 + public function getTitleForFeed() { 206 206 $author_phid = $this->getAuthorPHID(); 207 207 $object_phid = $this->getObjectPHID(); 208 208 ··· 250 250 } 251 251 } 252 252 253 253 - return parent::getTitleForFeed($story); 253 253 + return parent::getTitleForFeed(); 254 254 } 255 255 256 256 public function getBodyForFeed(PhabricatorFeedStory $story) {

+2 -2

src/applications/releeph/storage/ReleephProductTransaction.php

reviewed

··· 70 70 return parent::getTitle(); 71 71 } 72 72 73 73 - public function getTitleForFeed(PhabricatorFeedStory $story) { 73 73 + public function getTitleForFeed() { 74 74 $author_phid = $this->getAuthorPHID(); 75 75 $object_phid = $this->getObjectPHID(); 76 76 ··· 93 93 break; 94 94 } 95 95 96 96 - return parent::getTitleForFeed($story); 96 96 + return parent::getTitleForFeed(); 97 97 } 98 98 99 99 public function getNoEffectDescription() {

+2 -2

src/applications/transactions/feed/PhabricatorApplicationTransactionFeedStory.php

reviewed

··· 75 75 $xaction = $this->getPrimaryTransaction(); 76 76 77 77 $xaction->setHandles($this->getHandles()); 78 78 - $view->setTitle($xaction->getTitleForFeed($this)); 78 78 + $view->setTitle($xaction->getTitleForFeed()); 79 79 80 80 foreach ($xaction_phids as $xaction_phid) { 81 81 $secondary_xaction = $this->getObject($xaction_phid); ··· 99 99 $new_target = PhabricatorApplicationTransaction::TARGET_TEXT; 100 100 $xaction->setRenderingTarget($new_target); 101 101 $xaction->setHandles($this->getHandles()); 102 102 - $text = $xaction->getTitleForFeed($this); 102 102 + $text = $xaction->getTitleForFeed(); 103 103 $xaction->setRenderingTarget($old_target); 104 104 return $text; 105 105 }

+3 -3

src/applications/transactions/storage/PhabricatorApplicationTransaction.php

reviewed

··· 728 728 } 729 729 } 730 730 731 731 - public function getTitleForFeed(PhabricatorFeedStory $story) { 731 731 + public function getTitleForFeed() { 732 732 $author_phid = $this->getAuthorPHID(); 733 733 $object_phid = $this->getObjectPHID(); 734 734 ··· 802 802 case PhabricatorTransactions::TYPE_CUSTOMFIELD: 803 803 $field = $this->getTransactionCustomField(); 804 804 if ($field) { 805 805 - return $field->getApplicationTransactionTitleForFeed($this, $story); 805 805 + return $field->getApplicationTransactionTitleForFeed($this); 806 806 } else { 807 807 return pht( 808 808 '%s edited a custom field on %s.', ··· 1102 1102 if ($publisher->getRenderWithImpliedContext()) { 1103 1103 $text[] = $xaction->getTitle(); 1104 1104 } else { 1105 1105 - $text[] = $xaction->getTitleForFeed($story); 1105 1105 + $text[] = $xaction->getTitleForFeed(); 1106 1106 } 1107 1107 1108 1108 $xaction->setRenderingTarget($old_target);

+2 -4

src/infrastructure/customfield/field/PhabricatorCustomField.php

reviewed

··· 1003 1003 } 1004 1004 1005 1005 public function getApplicationTransactionTitleForFeed( 1006 1006 - PhabricatorApplicationTransaction $xaction, 1007 1007 - PhabricatorFeedStory $story) { 1006 1006 + PhabricatorApplicationTransaction $xaction) { 1008 1007 if ($this->proxy) { 1009 1008 return $this->proxy->getApplicationTransactionTitleForFeed( 1010 1010 - $xaction, 1011 1011 - $story); 1009 1009 + $xaction); 1012 1010 } 1013 1011 1014 1012 $author_phid = $xaction->getAuthorPHID();

+1 -2

src/infrastructure/customfield/standard/PhabricatorStandardCustomField.php

reviewed

··· 360 360 } 361 361 362 362 public function getApplicationTransactionTitleForFeed( 363 363 - PhabricatorApplicationTransaction $xaction, 364 364 - PhabricatorFeedStory $story) { 363 363 + PhabricatorApplicationTransaction $xaction) { 365 364 366 365 $author_phid = $xaction->getAuthorPHID(); 367 366 $object_phid = $xaction->getObjectPHID();