recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Use better variable names

Summary:
Use `p` and `c` instead of (reusing) `k`. This silences the following JSHint warning:

```
>>> Lint for webroot/rsrc/js/application/projects/behavior-project-boards.js:

Warning (W004) JSHintW004
'k' is already defined.

57 'phui-tag-shade-blue': (sum > 0 && !over_limit),
58 'phui-tag-shade-red': (over_limit)
59 };
>>> 60 for (var k in color_map) {
61 JX.DOM.alterClass(data.countTagNode, k, !!color_map[k]);
62 }
63 }
```

Test Plan: `arc lint`

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D11066

authored by

Joshua Spence and committed by
epriestley 02b28835 5251f08f

+15 -15
+11 -11
resources/celerity/map.php
··· 403 403 'rsrc/js/application/policy/behavior-policy-rule-editor.js' => 'fe9a552f', 404 404 'rsrc/js/application/ponder/behavior-votebox.js' => '4e9b766b', 405 405 'rsrc/js/application/projects/behavior-boards-dropdown.js' => '0ec56e1d', 406 - 'rsrc/js/application/projects/behavior-project-boards.js' => '0676345e', 406 + 'rsrc/js/application/projects/behavior-project-boards.js' => '8c2ab1e0', 407 407 'rsrc/js/application/projects/behavior-project-create.js' => '065227cc', 408 408 'rsrc/js/application/projects/behavior-reorder-columns.js' => 'e1d25dfb', 409 409 'rsrc/js/application/releeph/releeph-preview-branch.js' => 'b2b4fbaf', ··· 629 629 'javelin-behavior-policy-control' => 'f3fef818', 630 630 'javelin-behavior-policy-rule-editor' => 'fe9a552f', 631 631 'javelin-behavior-ponder-votebox' => '4e9b766b', 632 - 'javelin-behavior-project-boards' => '0676345e', 632 + 'javelin-behavior-project-boards' => '8c2ab1e0', 633 633 'javelin-behavior-project-create' => '065227cc', 634 634 'javelin-behavior-refresh-csrf' => '7814b593', 635 635 'javelin-behavior-releeph-preview-branch' => 'b2b4fbaf', ··· 847 847 'javelin-dom', 848 848 'javelin-stratcom', 849 849 'javelin-workflow', 850 - ), 851 - '0676345e' => array( 852 - 'javelin-behavior', 853 - 'javelin-dom', 854 - 'javelin-util', 855 - 'javelin-vector', 856 - 'javelin-stratcom', 857 - 'javelin-workflow', 858 - 'phabricator-draggable-list', 859 850 ), 860 851 '7319e029' => array( 861 852 'javelin-behavior', ··· 1367 1358 'javelin-util', 1368 1359 'javelin-request', 1369 1360 'javelin-typeahead-source', 1361 + ), 1362 + '8c2ab1e0' => array( 1363 + 'javelin-behavior', 1364 + 'javelin-dom', 1365 + 'javelin-util', 1366 + 'javelin-vector', 1367 + 'javelin-stratcom', 1368 + 'javelin-workflow', 1369 + 'phabricator-draggable-list', 1370 1370 ), 1371 1371 '8c49f386' => array( 1372 1372 'javelin-install',
+4 -4
webroot/rsrc/js/application/projects/behavior-project-boards.js
··· 48 48 'project-panel-over-limit': over_limit 49 49 }; 50 50 var panel = JX.DOM.findAbove(col, 'div', 'workpanel'); 51 - for (var k in panel_map) { 52 - JX.DOM.alterClass(panel, k, !!panel_map[k]); 51 + for (var p in panel_map) { 52 + JX.DOM.alterClass(panel, p, !!panel_map[p]); 53 53 } 54 54 55 55 var color_map = { ··· 57 57 'phui-tag-shade-blue': (sum > 0 && !over_limit), 58 58 'phui-tag-shade-red': (over_limit) 59 59 }; 60 - for (var k in color_map) { 61 - JX.DOM.alterClass(data.countTagNode, k, !!color_map[k]); 60 + for (var c in color_map) { 61 + JX.DOM.alterClass(data.countTagNode, c, !!color_map[c]); 62 62 } 63 63 } 64 64