recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Use `window.confirm` instead of `confirm`

Summary:
This silences the following JSHint warning:

```
>>> Lint for webroot/rsrc/js/application/uiexample/notification-example.js:

Warning (W117) JSHintW117
'confirm' is not defined.

39 notification.listen(
40 'activate',
41 function() {
>>> 42 if (!confirm('Close notification?')) {
43 JX.Stratcom.context().kill();
44 }
45 });

```

Test Plan: `arc lint`

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D11065

authored by

Joshua Spence and committed by
epriestley 5251f08f 558e1ee3

+12 -12
+10 -10
resources/celerity/map.php
··· 8 8 return array( 9 9 'names' => array( 10 10 'core.pkg.css' => 'f588bfc3', 11 - 'core.pkg.js' => '2d1f7db1', 11 + 'core.pkg.js' => '44aac665', 12 12 'darkconsole.pkg.js' => 'd326843f', 13 13 'differential.pkg.css' => '8af45893', 14 14 'differential.pkg.js' => '42c10e78', ··· 168 168 'rsrc/externals/javelin/core/init.js' => 'b88ab49e', 169 169 'rsrc/externals/javelin/core/init_node.js' => 'd7dde471', 170 170 'rsrc/externals/javelin/core/install.js' => '1ffb3a9c', 171 - 'rsrc/externals/javelin/core/util.js' => 'e7995242', 171 + 'rsrc/externals/javelin/core/util.js' => '90e3fde9', 172 172 'rsrc/externals/javelin/docs/Base.js' => '74676256', 173 173 'rsrc/externals/javelin/docs/onload.js' => 'e819c479', 174 174 'rsrc/externals/javelin/ext/fx/Color.js' => '7e41274a', ··· 427 427 'rsrc/js/application/uiexample/ReactorSendPropertiesExample.js' => 'b1f0ccee', 428 428 'rsrc/js/application/uiexample/busy-example.js' => '60479091', 429 429 'rsrc/js/application/uiexample/gesture-example.js' => '558829c2', 430 - 'rsrc/js/application/uiexample/notification-example.js' => '7a9677fc', 430 + 'rsrc/js/application/uiexample/notification-example.js' => '8ce821c5', 431 431 'rsrc/js/core/Busy.js' => '6453c869', 432 432 'rsrc/js/core/DragAndDropFileUpload.js' => '8c49f386', 433 433 'rsrc/js/core/DraggableList.js' => 'a16ec1c6', ··· 610 610 'javelin-behavior-phabricator-keyboard-shortcuts' => 'd75709e6', 611 611 'javelin-behavior-phabricator-line-linker' => '1499a8cb', 612 612 'javelin-behavior-phabricator-nav' => '14d7a8b8', 613 - 'javelin-behavior-phabricator-notification-example' => '7a9677fc', 613 + 'javelin-behavior-phabricator-notification-example' => '8ce821c5', 614 614 'javelin-behavior-phabricator-object-selector' => '49b73b36', 615 615 'javelin-behavior-phabricator-oncopy' => '2926fff2', 616 616 'javelin-behavior-phabricator-remarkup-assist' => 'e32d14ab', ··· 677 677 'javelin-typeahead-source' => 'fcba4ecc', 678 678 'javelin-typeahead-static-source' => '316b8fa1', 679 679 'javelin-uri' => '6eff08aa', 680 - 'javelin-util' => 'e7995242', 680 + 'javelin-util' => '90e3fde9', 681 681 'javelin-vector' => 'cc1bd0b0', 682 682 'javelin-view' => '0f764c35', 683 683 'javelin-view-html' => 'e5b406f9', ··· 1290 1290 'owners-path-editor', 1291 1291 'javelin-behavior', 1292 1292 ), 1293 - '7a9677fc' => array( 1294 - 'phabricator-notification', 1295 - 'javelin-stratcom', 1296 - 'javelin-behavior', 1297 - ), 1298 1293 '7b98d7c5' => array( 1299 1294 'javelin-behavior', 1300 1295 'javelin-dom', ··· 1380 1375 'javelin-dom', 1381 1376 'javelin-uri', 1382 1377 'phabricator-file-upload', 1378 + ), 1379 + '8ce821c5' => array( 1380 + 'phabricator-notification', 1381 + 'javelin-stratcom', 1382 + 'javelin-behavior', 1383 1383 ), 1384 1384 '8ef9ab58' => array( 1385 1385 'javelin-behavior',
+1 -1
webroot/rsrc/externals/javelin/core/util.js
··· 319 319 320 320 if (recent_alerts.length >= 3 && 321 321 (recent_alerts[recent_alerts.length - 1] - recent_alerts[0]) < 5000) { 322 - if (confirm(msg + "\n\nLots of alert()s recently. Kill them?")) { 322 + if (window.confirm(msg + "\n\nLots of alert()s recently. Kill them?")) { 323 323 window.alert = JX.bag; 324 324 } 325 325 } else {
+1 -1
webroot/rsrc/js/application/uiexample/notification-example.js
··· 39 39 notification.listen( 40 40 'activate', 41 41 function() { 42 - if (!confirm('Close notification?')) { 42 + if (!window.confirm('Close notification?')) { 43 43 JX.Stratcom.context().kill(); 44 44 } 45 45 });