@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Completely uninstall beta applications
Summary: Fixes T2357. In D4529, I recommended we just hide tiles for beta applications on installs without beta apps enabled. However, this creates at least a couple of issues, notably the stuff in T2357. The main app I was concerned wih Config, which we ended up un-beta'ing anyway, so I think this will probably solve more problems than it creates.
Test Plan: Verified routes for beta applications dropped out when beta was disabled. Verified "Customize Applications" no longer shows these applications.
Reviewers: ljalonen, chad
Reviewed By: chad
CC: aran
Maniphest Tasks: T2357
Differential Revision: https://secure.phabricator.com/D4546
+8
-5
+8
src/applications/base/PhabricatorApplication.php
+8
src/applications/base/PhabricatorApplication.php
···
204
204
public static function getAllInstalledApplications() {
205
205
static $applications;
206
206
207
+
$show_beta =
208
+
PhabricatorEnv::getEnvConfig('phabricator.show-beta-applications');
209
+
207
210
if (empty($applications)) {
208
211
$classes = id(new PhutilSymbolLoader())
209
212
->setAncestorClass(__CLASS__)
···
216
219
if (!$app->isEnabled()) {
217
220
continue;
218
221
}
222
+
223
+
if (!$show_beta && $app->isBeta()) {
224
+
continue;
225
+
}
226
+
219
227
$apps[] = $app;
220
228
}
221
229
$applications = $apps;
-5
src/applications/directory/controller/PhabricatorDirectoryController.php
-5
src/applications/directory/controller/PhabricatorDirectoryController.php
···
22
22
$nav->setBaseURI(new PhutilURI('/'));
23
23
24
24
$applications = PhabricatorApplication::getAllInstalledApplications();
25
-
$show_beta =
26
-
PhabricatorEnv::getEnvConfig('phabricator.show-beta-applications');
27
25
28
26
foreach ($applications as $key => $application) {
29
-
if (!$show_beta && $application->isBeta()) {
30
-
unset($applications[$key]);
31
-
}
32
27
if (!$application->shouldAppearInLaunchView()) {
33
28
// Remove hidden applications (usually internal stuff).
34
29
unset($applications[$key]);