recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Remove backticks from SQL statements

Summary: Remove backticks from SQL statements for consistency. In //most// places, we don't use backticks around table/field names, so at least be consistent about this.

Test Plan: Learned what backticks are used for in MySQL.

Reviewers: eadler, epriestley, #blessed_reviewers

Reviewed By: eadler, epriestley, #blessed_reviewers

Subscribers: epriestley

Differential Revision: https://secure.phabricator.com/D13267

Joshua Spence 070da828 69a9b5c3

+6 -6
+1 -1
src/applications/herald/garbagecollector/HeraldTranscriptGarbageCollector.php
··· 20 20 conditionTranscripts = "", 21 21 applyTranscripts = "", 22 22 garbageCollected = 1 23 - WHERE garbageCollected = 0 AND `time` < %d 23 + WHERE garbageCollected = 0 AND time < %d 24 24 LIMIT 100', 25 25 $table->getTableName(), 26 26 time() - $ttl);
+2 -2
src/applications/ponder/editor/PonderVoteEditor.php
··· 63 63 64 64 queryfx($conn, 65 65 'UPDATE %T as t 66 - SET t.`voteCount` = t.`voteCount` + %d 67 - WHERE t.`PHID` = %s', 66 + SET t.voteCount = t.voteCount + %d 67 + WHERE t.PHID = %s', 68 68 $votable->getTableName(), 69 69 $delta, 70 70 $votable->getVotablePHID());
+3 -3
src/applications/xhprof/controller/PhabricatorXHProfSampleListController.php
··· 18 18 19 19 switch ($this->view) { 20 20 case 'sampled': 21 - $clause = '`sampleRate` > 0'; 21 + $clause = 'sampleRate > 0'; 22 22 $show_type = false; 23 23 break; 24 24 case 'my-runs': 25 25 $clause = qsprintf( 26 26 id(new PhabricatorXHProfSample())->establishConnection('r'), 27 - '`sampleRate` = 0 AND `userPHID` = %s', 27 + 'sampleRate = 0 AND userPHID = %s', 28 28 $request->getUser()->getPHID()); 29 29 $show_type = false; 30 30 break; 31 31 case 'manual': 32 - $clause = '`sampleRate` = 0'; 32 + $clause = 'sampleRate = 0'; 33 33 $show_type = false; 34 34 break; 35 35 case 'all':