@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Change setErrorView to setInfoView in PHUIObjectBoxView

Summary: Renames the method in PHUIObjectBoxView to match the new PHUIInfoView class.

Test Plan: grepped codebase. Went to Calendar and tried a new status.

Reviewers: btrahan, epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D12005

+24 -24
+1 -1
src/applications/almanac/controller/AlmanacController.php
··· 195 195 array($message, ' ', $doc_link), 196 196 )); 197 197 198 - $box->setErrorView($error_view); 198 + $box->setInfoView($error_view); 199 199 } 200 200 201 201 }
+1 -1
src/applications/auth/controller/config/PhabricatorAuthListController.php
··· 161 161 $list->setFlush(true); 162 162 $list = id(new PHUIObjectBoxView()) 163 163 ->setHeader($header) 164 - ->setErrorView($warning) 164 + ->setInfoView($warning) 165 165 ->appendChild($list); 166 166 167 167 return $this->buildApplicationPage(
+1 -1
src/applications/calendar/controller/PhabricatorCalendarViewController.php
··· 42 42 $month_view->setUser($user); 43 43 $month_view->setHolidays($holidays); 44 44 if ($this->getNoticeView()) { 45 - $month_view->setErrorView($this->getNoticeView()); 45 + $month_view->setInfoView($this->getNoticeView()); 46 46 } 47 47 48 48 $phids = mpull($statuses, 'getUserPHID');
+1 -1
src/applications/config/controller/PhabricatorConfigEditController.php
··· 202 202 ->setForm($form); 203 203 204 204 if ($error_view) { 205 - $form_box->setErrorView($error_view); 205 + $form_box->setInfoView($error_view); 206 206 } 207 207 208 208 $crumbs = $this->buildApplicationCrumbs();
+1 -1
src/applications/dashboard/controller/PhabricatorDashboardManageController.php
··· 55 55 'You do not have permission to edit this dashboard. If you want to '. 56 56 'make changes, make a copy first.'); 57 57 58 - $box->setErrorView( 58 + $box->setInfoView( 59 59 id(new PHUIInfoView()) 60 60 ->setSeverity(PHUIInfoView::SEVERITY_NOTICE) 61 61 ->setErrors(array($no_edit)));
+1 -1
src/applications/differential/controller/DifferentialDiffViewController.php
··· 129 129 $prop_box = id(new PHUIObjectBoxView()) 130 130 ->setHeader($property_head) 131 131 ->addPropertyList($property_view) 132 - ->setErrorView($error_view); 132 + ->setInfoView($error_view); 133 133 134 134 return $this->buildApplicationPage( 135 135 array(
+2 -2
src/applications/differential/controller/DifferentialRevisionViewController.php
··· 261 261 $revision_warnings = id(new PHUIInfoView()) 262 262 ->setSeverity(PHUIInfoView::SEVERITY_WARNING) 263 263 ->setErrors($revision_warnings); 264 - $revision_detail_box->setErrorView($revision_warnings); 264 + $revision_detail_box->setInfoView($revision_warnings); 265 265 } 266 266 267 267 $comment_view = $this->buildTransactions( ··· 389 389 $review_warnings_panel = id(new PHUIInfoView()) 390 390 ->setSeverity(PHUIInfoView::SEVERITY_WARNING) 391 391 ->setErrors($review_warnings); 392 - $comment_form->setErrorView($review_warnings_panel); 392 + $comment_form->setInfoView($review_warnings_panel); 393 393 } 394 394 395 395 $comment_form->setActions($this->getRevisionCommentActions($revision));
+2 -2
src/applications/differential/view/DifferentialAddCommentView.php
··· 10 10 private $ccs = array(); 11 11 private $errorView; 12 12 13 - public function setErrorView(PHUIInfoView $error_view) { 13 + public function setInfoView(PHUIInfoView $error_view) { 14 14 $this->errorView = $error_view; 15 15 return $this; 16 16 } ··· 188 188 ->appendChild($form); 189 189 190 190 if ($this->errorView) { 191 - $comment_box->setErrorView($this->errorView); 191 + $comment_box->setInfoView($this->errorView); 192 192 } 193 193 194 194 return array($comment_box, $preview);
+2 -2
src/applications/diffusion/controller/DiffusionCommitController.php
··· 257 257 ->appendChild( 258 258 pht('This commit is very large. Load each file individually.')); 259 259 260 - $change_panel->setErrorView($warning_view); 260 + $change_panel->setInfoView($warning_view); 261 261 $header->addActionLink($button); 262 262 } 263 263 ··· 920 920 $panel->setHeaderText(pht('Merged Changes')); 921 921 $panel->appendChild($history_table); 922 922 if ($caption) { 923 - $panel->setErrorView($caption); 923 + $panel->setInfoView($caption); 924 924 } 925 925 926 926 return $panel;
+1 -1
src/applications/diffusion/controller/DiffusionExternalController.php
··· 131 131 132 132 $content = new PHUIObjectBoxView(); 133 133 $content->setHeaderText(pht('Multiple Matching Commits')); 134 - $content->setErrorView($caption); 134 + $content->setInfoView($caption); 135 135 $content->appendChild($table); 136 136 } 137 137
+1 -1
src/applications/legalpad/query/LegalpadDocumentSignatureSearchEngine.php
··· 301 301 'NOTE: You can only see your own signatures and signatures on '. 302 302 'documents you have permission to edit.'), 303 303 )); 304 - $box->setErrorView($policy_notice); 304 + $box->setInfoView($policy_notice); 305 305 } 306 306 307 307 return $box;
+1 -1
src/applications/maniphest/controller/ManiphestReportController.php
··· 270 270 $panel = new PHUIObjectBoxView(); 271 271 $panel->setHeaderText($header); 272 272 if ($caption) { 273 - $panel->setErrorView($caption); 273 + $panel->setInfoView($caption); 274 274 } 275 275 $panel->appendChild($table); 276 276
+1 -1
src/applications/maniphest/controller/ManiphestTaskDetailController.php
··· 351 351 ->addPropertyList($properties); 352 352 353 353 if ($info_view) { 354 - $object_box->setErrorView($info_view); 354 + $object_box->setInfoView($info_view); 355 355 } 356 356 357 357 if ($description) {
+1 -1
src/applications/people/controller/PhabricatorPeopleInviteSendController.php
··· 158 158 } 159 159 160 160 $confirm_box = id(new PHUIObjectBoxView()) 161 - ->setErrorView( 161 + ->setInfoView( 162 162 id(new PHUIInfoView()) 163 163 ->setErrors($confirm_errors) 164 164 ->setSeverity($severity))
+1 -1
src/applications/phortune/controller/PhortuneCartViewController.php
··· 123 123 if ($errors) { 124 124 $cart_box->setFormErrors($errors); 125 125 } else if ($error_view) { 126 - $cart_box->setErrorView($error_view); 126 + $cart_box->setInfoView($error_view); 127 127 } 128 128 129 129 $charges = id(new PhortuneChargeQuery())
+4 -4
src/view/phui/PHUIObjectBoxView.php
··· 6 6 private $headerColor; 7 7 private $formErrors = null; 8 8 private $formSaved = false; 9 - private $errorView; 9 + private $infoView; 10 10 private $form; 11 11 private $validationException; 12 12 private $header; ··· 113 113 return $this; 114 114 } 115 115 116 - public function setErrorView(PHUIInfoView $view) { 117 - $this->errorView = $view; 116 + public function setInfoView(PHUIInfoView $view) { 117 + $this->infoView = $view; 118 118 return $this; 119 119 } 120 120 ··· 269 269 ->appendChild( 270 270 array( 271 271 $header, 272 - $this->errorView, 272 + $this->infoView, 273 273 $this->formErrors, 274 274 $this->formSaved, 275 275 $exception_errors,
+2 -2
src/view/phui/calendar/PHUICalendarMonthView.php
··· 29 29 return $this; 30 30 } 31 31 32 - public function setErrorView(PHUIInfoView $error) { 32 + public function setInfoView(PHUIInfoView $error) { 33 33 $this->error = $error; 34 34 return $this; 35 35 } ··· 192 192 ->setHeader($this->renderCalendarHeader($first)) 193 193 ->appendChild($table); 194 194 if ($this->error) { 195 - $box->setErrorView($this->error); 195 + $box->setInfoView($this->error); 196 196 197 197 } 198 198