@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix fatal when deleted user is subscribed to a task and we generate an email to them
Summary: Fixes T3528. We won't be able to load the user if they've been deleted, and will fatal a few lines later on `$user->getID()`.
Test Plan: I'm going with my gut on this one.
Reviewers: btrahan
Reviewed By: btrahan
CC: aran
Maniphest Tasks: T3528
Differential Revision: https://secure.phabricator.com/D6442
+6
+6
src/applications/metamta/replyhandler/PhabricatorMailReplyHandler.php
+6
src/applications/metamta/replyhandler/PhabricatorMailReplyHandler.php
···
290
290
->withPHIDs(array($handle->getPHID()))
291
291
->executeOne();
292
292
293
+
if (!$user) {
294
+
// This may happen if a user was subscribed to something, and was then
295
+
// deleted.
296
+
return null;
297
+
}
298
+
293
299
$receiver = $this->getMailReceiver();
294
300
$receiver_id = $receiver->getID();
295
301
$user_id = $user->getID();