@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Use authoritative PHIDs for Herald "Task Projects" condition
Summary:
Fixes T5707. After work on T5245, the `$task` object may not have the correct set of task PHIDs attached to it when Herald is invoked.
Instead, just fetch the authoritative set. This is simple, and Herald is not super performance sensitive (happens on a write) so hitting the DB once is fine.
Test Plan: Created a task with projects, verified the projects field contained the correct values when processed by Herald.
Reviewers: chad, btrahan, joshuaspence
Reviewed By: joshuaspence
Subscribers: epriestley
Maniphest Tasks: T5707
Differential Revision: https://secure.phabricator.com/D10060
+3
-1
+3
-1
src/applications/herald/adapter/HeraldManiphestTaskAdapter.php
+3
-1
src/applications/herald/adapter/HeraldManiphestTaskAdapter.php
···
140
140
case self::FIELD_CC:
141
141
return $this->getTask()->getCCPHIDs();
142
142
case self::FIELD_PROJECTS:
143
-
return $this->getTask()->getProjectPHIDs();
143
+
return PhabricatorEdgeQuery::loadDestinationPHIDs(
144
+
$this->getTask()->getPHID(),
145
+
PhabricatorProjectObjectHasProjectEdgeType::EDGECONST);
144
146
case self::FIELD_TASK_PRIORITY:
145
147
return $this->getTask()->getPriority();
146
148
}