@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix undefined variable in HeraldAction
Summary: `$no_permission` is only defined within `if ($object instanceof PhabricatorPolicyInterface)`, thus move the check for `if ($no_permission)` into that clause.
Test Plan: Read the code.
Reviewers: O1 Blessed Committers, valerio.bozzolan
Reviewed By: O1 Blessed Committers, valerio.bozzolan
Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno
Differential Revision: https://we.phorge.it/D25741
+3
-4
+3
-4
src/applications/herald/action/HeraldAction.php
+3
-4
src/applications/herald/action/HeraldAction.php
···
298
298
$no_permission[] = $phid;
299
299
unset($targets[$phid]);
300
300
}
301
-
}
302
-
303
-
if ($no_permission) {
304
-
$this->logEffect(self::DO_STANDARD_PERMISSION, $no_permission);
301
+
if ($no_permission) {
302
+
$this->logEffect(self::DO_STANDARD_PERMISSION, $no_permission);
303
+
}
305
304
}
306
305
307
306
return $targets;