@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Use textContent instead of innerHTML for linking symbols
Summary: Go to https://secure.phabricator.com/D2646#59cc9d49 and click on `array_mergev` to repro.
Test Plan: Checked if the property exists in DOM inspector.
Reviewers: epriestley
Reviewed By: epriestley
CC: aran, Korvin
Differential Revision: https://secure.phabricator.com/D2742
+23
-22
+21
-21
src/__celerity_resource_map__.php
+21
-21
src/__celerity_resource_map__.php
···
1439
1439
),
1440
1440
'javelin-behavior-repository-crossreference' =>
1441
1441
array(
1442
-
'uri' => '/res/49472f48/rsrc/js/application/repository/repository-crossreference.js',
1442
+
'uri' => '/res/8e4bbed2/rsrc/js/application/repository/repository-crossreference.js',
1443
1443
'type' => 'js',
1444
1444
'requires' =>
1445
1445
array(
···
2592
2592
'uri' => '/res/pkg/32f461a4/differential.pkg.css',
2593
2593
'type' => 'css',
2594
2594
),
2595
-
'86f654e2' =>
2595
+
'3590beb8' =>
2596
2596
array(
2597
2597
'name' => 'differential.pkg.js',
2598
2598
'symbols' =>
···
2616
2616
16 => 'javelin-behavior-differential-dropdown-menus',
2617
2617
17 => 'javelin-behavior-buoyant',
2618
2618
),
2619
-
'uri' => '/res/pkg/86f654e2/differential.pkg.js',
2619
+
'uri' => '/res/pkg/3590beb8/differential.pkg.js',
2620
2620
'type' => 'js',
2621
2621
),
2622
2622
'c8ce2d88' =>
···
2724
2724
'aphront-typeahead-control-css' => '040e796f',
2725
2725
'differential-changeset-view-css' => '32f461a4',
2726
2726
'differential-core-view-css' => '32f461a4',
2727
-
'differential-inline-comment-editor' => '86f654e2',
2727
+
'differential-inline-comment-editor' => '3590beb8',
2728
2728
'differential-local-commits-view-css' => '32f461a4',
2729
2729
'differential-results-table-css' => '32f461a4',
2730
2730
'differential-revision-add-comment-css' => '32f461a4',
···
2737
2737
'inline-comment-summary-css' => '32f461a4',
2738
2738
'javelin-behavior' => '6fb20113',
2739
2739
'javelin-behavior-aphront-basic-tokenizer' => '97f65640',
2740
-
'javelin-behavior-aphront-drag-and-drop' => '86f654e2',
2741
-
'javelin-behavior-aphront-drag-and-drop-textarea' => '86f654e2',
2740
+
'javelin-behavior-aphront-drag-and-drop' => '3590beb8',
2741
+
'javelin-behavior-aphront-drag-and-drop-textarea' => '3590beb8',
2742
2742
'javelin-behavior-aphront-form-disable-on-submit' => '0c96375e',
2743
2743
'javelin-behavior-audit-preview' => '5e68be89',
2744
-
'javelin-behavior-buoyant' => '86f654e2',
2745
-
'javelin-behavior-differential-accept-with-errors' => '86f654e2',
2746
-
'javelin-behavior-differential-add-reviewers-and-ccs' => '86f654e2',
2747
-
'javelin-behavior-differential-comment-jump' => '86f654e2',
2748
-
'javelin-behavior-differential-diff-radios' => '86f654e2',
2749
-
'javelin-behavior-differential-dropdown-menus' => '86f654e2',
2750
-
'javelin-behavior-differential-edit-inline-comments' => '86f654e2',
2751
-
'javelin-behavior-differential-feedback-preview' => '86f654e2',
2752
-
'javelin-behavior-differential-keyboard-navigation' => '86f654e2',
2753
-
'javelin-behavior-differential-populate' => '86f654e2',
2754
-
'javelin-behavior-differential-show-more' => '86f654e2',
2744
+
'javelin-behavior-buoyant' => '3590beb8',
2745
+
'javelin-behavior-differential-accept-with-errors' => '3590beb8',
2746
+
'javelin-behavior-differential-add-reviewers-and-ccs' => '3590beb8',
2747
+
'javelin-behavior-differential-comment-jump' => '3590beb8',
2748
+
'javelin-behavior-differential-diff-radios' => '3590beb8',
2749
+
'javelin-behavior-differential-dropdown-menus' => '3590beb8',
2750
+
'javelin-behavior-differential-edit-inline-comments' => '3590beb8',
2751
+
'javelin-behavior-differential-feedback-preview' => '3590beb8',
2752
+
'javelin-behavior-differential-keyboard-navigation' => '3590beb8',
2753
+
'javelin-behavior-differential-populate' => '3590beb8',
2754
+
'javelin-behavior-differential-show-more' => '3590beb8',
2755
2755
'javelin-behavior-diffusion-commit-graph' => '5e68be89',
2756
2756
'javelin-behavior-diffusion-pull-lastmodified' => '5e68be89',
2757
2757
'javelin-behavior-maniphest-batch-selector' => '7707de41',
···
2761
2761
'javelin-behavior-maniphest-transaction-preview' => '7707de41',
2762
2762
'javelin-behavior-phabricator-autofocus' => '0c96375e',
2763
2763
'javelin-behavior-phabricator-keyboard-shortcuts' => '0c96375e',
2764
-
'javelin-behavior-phabricator-object-selector' => '86f654e2',
2764
+
'javelin-behavior-phabricator-object-selector' => '3590beb8',
2765
2765
'javelin-behavior-phabricator-oncopy' => '0c96375e',
2766
2766
'javelin-behavior-phabricator-tooltips' => '0c96375e',
2767
2767
'javelin-behavior-phabricator-watch-anchor' => '0c96375e',
2768
2768
'javelin-behavior-refresh-csrf' => '0c96375e',
2769
-
'javelin-behavior-repository-crossreference' => '86f654e2',
2769
+
'javelin-behavior-repository-crossreference' => '3590beb8',
2770
2770
'javelin-behavior-workflow' => '0c96375e',
2771
2771
'javelin-dom' => '6fb20113',
2772
2772
'javelin-event' => '6fb20113',
···
2792
2792
'phabricator-core-buttons-css' => '040e796f',
2793
2793
'phabricator-core-css' => '040e796f',
2794
2794
'phabricator-directory-css' => '040e796f',
2795
-
'phabricator-drag-and-drop-file-upload' => '86f654e2',
2795
+
'phabricator-drag-and-drop-file-upload' => '3590beb8',
2796
2796
'phabricator-dropdown-menu' => '0c96375e',
2797
2797
'phabricator-flag-css' => '040e796f',
2798
2798
'phabricator-jump-nav' => '040e796f',
···
2804
2804
'phabricator-prefab' => '0c96375e',
2805
2805
'phabricator-project-tag-css' => '7839ae2d',
2806
2806
'phabricator-remarkup-css' => '040e796f',
2807
-
'phabricator-shaped-request' => '86f654e2',
2807
+
'phabricator-shaped-request' => '3590beb8',
2808
2808
'phabricator-standard-page-view' => '040e796f',
2809
2809
'phabricator-tooltip' => '0c96375e',
2810
2810
'phabricator-transaction-view-css' => '040e796f',
+2
-1
webroot/rsrc/js/application/repository/repository-crossreference.js
+2
-1
webroot/rsrc/js/application/repository/repository-crossreference.js
···
20
20
var target = e.getTarget();
21
21
var map = {nc : 'class', nf : 'function'};
22
22
if (JX.DOM.isNode(target, 'span') && (target.className in map)) {
23
-
var uri = JX.$U('/diffusion/symbol/' + target.innerHTML + '/');
23
+
var symbol = target.textContent || target.innerText;
24
+
var uri = JX.$U('/diffusion/symbol/' + symbol + '/');
24
25
uri.addQueryParams({
25
26
type : map[target.className],
26
27
lang : config.lang,