@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Update Almanac for newPage
Summary: Swaps out for modern methods. Ref T9690
Test Plan: Check various Almanac pages, new devices, editing, lists.
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Maniphest Tasks: T9690
Differential Revision: https://secure.phabricator.com/D14590
+71
-79
+7
-7
src/applications/almanac/controller/AlmanacBindingEditController.php
+7
-7
src/applications/almanac/controller/AlmanacBindingEditController.php
···
110
110
$crumbs->addTextCrumb(pht('Edit Binding'));
111
111
}
112
112
113
-
return $this->buildApplicationPage(
114
-
array(
115
-
$crumbs,
116
-
$box,
117
-
),
118
-
array(
119
-
'title' => $title,
113
+
return $this->newPage()
114
+
->setTitle($title)
115
+
->setCrumbs($crumbs)
116
+
->appendChild(
117
+
array(
118
+
$box,
120
119
));
120
+
121
121
}
122
122
123
123
}
+8
-9
src/applications/almanac/controller/AlmanacBindingViewController.php
+8
-9
src/applications/almanac/controller/AlmanacBindingViewController.php
···
55
55
new AlmanacBindingTransactionQuery());
56
56
$timeline->setShouldTerminate(true);
57
57
58
-
return $this->buildApplicationPage(
59
-
array(
60
-
$crumbs,
61
-
$box,
62
-
$this->buildAlmanacPropertiesTable($binding),
63
-
$timeline,
64
-
),
65
-
array(
66
-
'title' => $title,
58
+
return $this->newPage()
59
+
->setTitle($title)
60
+
->setCrumbs($crumbs)
61
+
->appendChild(
62
+
array(
63
+
$box,
64
+
$this->buildAlmanacPropertiesTable($binding),
65
+
$timeline,
67
66
));
68
67
}
69
68
+7
-7
src/applications/almanac/controller/AlmanacConsoleController.php
+7
-7
src/applications/almanac/controller/AlmanacConsoleController.php
···
40
40
->setHeaderText(pht('Console'))
41
41
->setObjectList($menu);
42
42
43
-
return $this->buildApplicationPage(
44
-
array(
45
-
$crumbs,
46
-
$box,
47
-
),
48
-
array(
49
-
'title' => pht('Almanac Console'),
43
+
return $this->newPage()
44
+
->setTitle(pht('Almanac Console'))
45
+
->setCrumbs($crumbs)
46
+
->appendChild(
47
+
array(
48
+
$box,
50
49
));
50
+
51
51
}
52
52
53
53
}
+6
-7
src/applications/almanac/controller/AlmanacDeviceEditController.php
+6
-7
src/applications/almanac/controller/AlmanacDeviceEditController.php
···
151
151
$crumbs->addTextCrumb(pht('Edit'));
152
152
}
153
153
154
-
return $this->buildApplicationPage(
155
-
array(
156
-
$crumbs,
157
-
$box,
158
-
),
159
-
array(
160
-
'title' => $title,
154
+
return $this->newPage()
155
+
->setTitle($title)
156
+
->setCrumbs($crumbs)
157
+
->appendChild(
158
+
array(
159
+
$box,
161
160
));
162
161
}
163
162
+11
-12
src/applications/almanac/controller/AlmanacDeviceViewController.php
+11
-12
src/applications/almanac/controller/AlmanacDeviceViewController.php
···
57
57
new AlmanacDeviceTransactionQuery());
58
58
$timeline->setShouldTerminate(true);
59
59
60
-
return $this->buildApplicationPage(
61
-
array(
62
-
$crumbs,
63
-
$box,
64
-
$interfaces,
65
-
$this->buildAlmanacPropertiesTable($device),
66
-
$this->buildSSHKeysTable($device),
67
-
$this->buildServicesTable($device),
68
-
$timeline,
69
-
),
70
-
array(
71
-
'title' => $title,
60
+
return $this->newPage()
61
+
->setTitle($title)
62
+
->setCrumbs($crumbs)
63
+
->appendChild(
64
+
array(
65
+
$box,
66
+
$interfaces,
67
+
$this->buildAlmanacPropertiesTable($device),
68
+
$this->buildSSHKeysTable($device),
69
+
$this->buildServicesTable($device),
70
+
$timeline,
72
71
));
73
72
}
74
73
+6
-7
src/applications/almanac/controller/AlmanacInterfaceEditController.php
+6
-7
src/applications/almanac/controller/AlmanacInterfaceEditController.php
···
142
142
$crumbs->addTextCrumb(pht('Edit Interface'));
143
143
}
144
144
145
-
return $this->buildApplicationPage(
146
-
array(
147
-
$crumbs,
148
-
$box,
149
-
),
150
-
array(
151
-
'title' => $title,
145
+
return $this->newPage()
146
+
->setTitle($title)
147
+
->setCrumbs($crumbs)
148
+
->appendChild(
149
+
array(
150
+
$box,
152
151
));
153
152
}
154
153
+6
-7
src/applications/almanac/controller/AlmanacNetworkEditController.php
+6
-7
src/applications/almanac/controller/AlmanacNetworkEditController.php
···
130
130
$crumbs->addTextCrumb(pht('Edit'));
131
131
}
132
132
133
-
return $this->buildApplicationPage(
134
-
array(
135
-
$crumbs,
136
-
$box,
137
-
),
138
-
array(
139
-
'title' => $title,
133
+
return $this->newPage()
134
+
->setTitle($title)
135
+
->setCrumbs($crumbs)
136
+
->appendChild(
137
+
array(
138
+
$box,
140
139
));
141
140
}
142
141
+7
-8
src/applications/almanac/controller/AlmanacNetworkViewController.php
+7
-8
src/applications/almanac/controller/AlmanacNetworkViewController.php
···
42
42
new AlmanacNetworkTransactionQuery());
43
43
$timeline->setShouldTerminate(true);
44
44
45
-
return $this->buildApplicationPage(
46
-
array(
47
-
$crumbs,
48
-
$box,
49
-
$timeline,
50
-
),
51
-
array(
52
-
'title' => $title,
45
+
return $this->newPage()
46
+
->setTitle($title)
47
+
->setCrumbs($crumbs)
48
+
->appendChild(
49
+
array(
50
+
$box,
51
+
$timeline,
53
52
));
54
53
}
55
54
+6
-7
src/applications/almanac/controller/AlmanacServiceEditController.php
+6
-7
src/applications/almanac/controller/AlmanacServiceEditController.php
···
168
168
$crumbs->addTextCrumb(pht('Edit'));
169
169
}
170
170
171
-
return $this->buildApplicationPage(
172
-
array(
173
-
$crumbs,
174
-
$box,
175
-
),
176
-
array(
177
-
'title' => $title,
171
+
return $this->newPage()
172
+
->setTitle($title)
173
+
->setCrumbs($crumbs)
174
+
->appendChild(
175
+
array(
176
+
$box,
178
177
));
179
178
}
180
179
+7
-8
src/applications/almanac/controller/AlmanacServiceViewController.php
+7
-8
src/applications/almanac/controller/AlmanacServiceViewController.php
···
56
56
new AlmanacServiceTransactionQuery());
57
57
$timeline->setShouldTerminate(true);
58
58
59
-
return $this->buildApplicationPage(
60
-
array(
61
-
$crumbs,
62
-
$box,
59
+
return $this->newPage()
60
+
->setTitle($title)
61
+
->setCrumbs($crumbs)
62
+
->appendChild(
63
+
array(
64
+
$box,
63
65
$bindings,
64
66
$this->buildAlmanacPropertiesTable($service),
65
67
$timeline,
66
-
),
67
-
array(
68
-
'title' => $title,
69
-
));
68
+
));
70
69
}
71
70
72
71
private function buildPropertyList(AlmanacService $service) {