recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix PHP 8.1 "strlen(null)" exception for "/bin/herald test" without parameter

Summary:
`strlen()` was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

This patch also fixes another similar strlen() occurrence in the same source file.

```
ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/herald/management/HeraldTestManagementWorkflow.php:33]
```

Test Plan: Run `../phorge/bin/herald test`: Get no `strlen()` error anymore but only expected output `Usage Exception: Specify an object to test rules for with "--object".`

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Differential Revision: https://we.phorge.it/D25586

Andre Klapper 0e53f91c d630f228

+2 -2
+2 -2
src/applications/herald/management/HeraldTestManagementWorkflow.php
··· 30 30 $viewer = $this->getViewer(); 31 31 32 32 $object_name = $args->getArg('object'); 33 - if (!strlen($object_name)) { 33 + if (!phutil_nonempty_string($object_name)) { 34 34 throw new PhutilArgumentUsageException( 35 35 pht('Specify an object to test rules for with "--object".')); 36 36 } ··· 69 69 70 70 71 71 $content_type = $args->getArg('type'); 72 - if (!strlen($content_type)) { 72 + if (!phutil_nonempty_string($content_type)) { 73 73 throw new PhutilArgumentUsageException( 74 74 pht( 75 75 'Specify a content type to run rules for. For this object, valid '.