@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Remove janky array copying workaround for IE8
Summary:
Internet Explorer 8 and earlier did not consider DOM NodeLists to be JS objects.
In different words: IE<9 did not support Array#slice on collections objects.
See for example https://stackoverflow.com/a/11113539
This reverts rP597c6c07f7120d253e83fa110db8842bfa05859f
Test Plan: Still: Load a diff in a web browser; see changes and do not get JS errors.
Reviewers: O1 Blessed Committers, mainframe98
Reviewed By: O1 Blessed Committers, mainframe98
Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno
Differential Revision: https://we.phorge.it/D25704
+4
-10
+3
-3
resources/celerity/map.php
+3
-3
resources/celerity/map.php
···
10
10
'conpherence.pkg.css' => '79a197f6',
11
11
'conpherence.pkg.js' => '020aebcf',
12
12
'core.pkg.css' => 'ed73eb65',
13
-
'core.pkg.js' => '086da722',
13
+
'core.pkg.js' => '63f896ec',
14
14
'dark-console.pkg.js' => '187792c2',
15
15
'differential.pkg.css' => 'db7c5008',
16
16
'differential.pkg.js' => '46fcb3af',
···
215
215
'rsrc/externals/javelin/core/init.js' => '98e6504a',
216
216
'rsrc/externals/javelin/core/init_node.js' => '16961339',
217
217
'rsrc/externals/javelin/core/install.js' => '5902260c',
218
-
'rsrc/externals/javelin/core/util.js' => 'edb4d8c9',
218
+
'rsrc/externals/javelin/core/util.js' => '472cda1c',
219
219
'rsrc/externals/javelin/docs/Base.js' => '5a401d7d',
220
220
'rsrc/externals/javelin/docs/onload.js' => 'ee58fb62',
221
221
'rsrc/externals/javelin/ext/fx/Color.js' => '78f811c9',
···
717
717
'javelin-typeahead-source' => '8badee71',
718
718
'javelin-typeahead-static-source' => '80bff3af',
719
719
'javelin-uri' => '2e255291',
720
-
'javelin-util' => 'edb4d8c9',
720
+
'javelin-util' => '472cda1c',
721
721
'javelin-vector' => 'e9c80beb',
722
722
'javelin-view' => '289bf236',
723
723
'javelin-view-html' => 'f8c4e135',
+1
-7
webroot/rsrc/externals/javelin/core/util.js
+1
-7
webroot/rsrc/externals/javelin/core/util.js
···
45
45
* @return Array Actual array.
46
46
*/
47
47
JX.$A = function(object) {
48
-
// IE8 throws "JScript object expected" when trying to call
49
-
// Array.prototype.slice on a NodeList, so just copy items one by one here.
50
-
var r = [];
51
-
for (var ii = 0; ii < object.length; ii++) {
52
-
r.push(object[ii]);
53
-
}
54
-
return r;
48
+
return Array.prototype.slice.call(object);
55
49
};
56
50
57
51