recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix application name toolip hover

Summary: Ref T12174. We were always setting a name via builtins so the tooltip was always set. Fix the calls here.

Test Plan: Add "Badges", see tooltip, give "Badges" a name of "Badges", don't see tooltip.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Maniphest Tasks: T12174

Differential Revision: https://secure.phabricator.com/D17284

Chad Little 113bdd9f 7fc8e197

+3 -2
+1 -1
src/applications/home/engine/PhabricatorHomeProfileMenuEngine.php
··· 39 39 } 40 40 41 41 $properties = array( 42 - 'name' => $application->getName(), 42 + 'name' => '', 43 43 'application' => $application->getPHID(), 44 44 ); 45 45
+2 -1
src/applications/search/menuitem/PhabricatorApplicationProfileMenuItem.php
··· 89 89 ->setIcon($app->getIcon()); 90 90 91 91 // Don't show tooltip if they've set a custom name 92 - if (strlen(($config->getMenuItemProperty('name')))) { 92 + $name = $config->getMenuItemProperty('name'); 93 + if (!strlen($name)) { 93 94 $item->setTooltip($app->getShortDescription()); 94 95 } 95 96