@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Use "phutil_string_cast()" in TypeaheadDatasource
Summary:
Depends on D20138. Ref T13250. This improves exception behavior and gives us a standard page with a stack trace instead of a text fatal with no stack trace.
Truly a great day for PHP.
(Eventually we may want to replace all `(string)` with `phutil_string_cast()`, but let's let it have some time in the wild first?)
Test Plan: Triggered the error, got a more useful exception behavior.
Reviewers: amckinley
Reviewed By: amckinley
Maniphest Tasks: T13250
Differential Revision: https://secure.phabricator.com/D20140
+2
-2
+2
-2
src/applications/typeahead/datasource/PhabricatorTypeaheadDatasource.php
+2
-2
src/applications/typeahead/datasource/PhabricatorTypeaheadDatasource.php
···
101
101
public function getDatasourceURI() {
102
102
$uri = new PhutilURI('/typeahead/class/'.get_class($this).'/');
103
103
$uri->setQueryParams($this->newURIParameters());
104
-
return (string)$uri;
104
+
return phutil_string_cast($uri);
105
105
}
106
106
107
107
public function getBrowseURI() {
···
111
111
112
112
$uri = new PhutilURI('/typeahead/browse/'.get_class($this).'/');
113
113
$uri->setQueryParams($this->newURIParameters());
114
-
return (string)$uri;
114
+
return phutil_string_cast($uri);
115
115
}
116
116
117
117
private function newURIParameters() {