@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Grid spacing for full Conpherence thread list

Summary: Moves to 4px grid / alignment.

Test Plan: Tested per photoshop gridlines, spacing measurements.

Reviewers: btrahan, epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D12197

+21 -11
+2 -2
resources/celerity/map.php
··· 45 45 'rsrc/css/application/config/setup-issue.css' => '22270af2', 46 46 'rsrc/css/application/config/unhandled-exception.css' => '37d4f9a2', 47 47 'rsrc/css/application/conpherence/durable-column.css' => 'e2011d85', 48 - 'rsrc/css/application/conpherence/menu.css' => '9b37a261', 48 + 'rsrc/css/application/conpherence/menu.css' => '2c1c727c', 49 49 'rsrc/css/application/conpherence/message-pane.css' => '44154798', 50 50 'rsrc/css/application/conpherence/notification.css' => '04a6e10a', 51 51 'rsrc/css/application/conpherence/update.css' => '1099a660', ··· 515 515 'config-options-css' => '7fedf08b', 516 516 'config-welcome-css' => '6abd79be', 517 517 'conpherence-durable-column-view' => 'e2011d85', 518 - 'conpherence-menu-css' => '9b37a261', 518 + 'conpherence-menu-css' => '2c1c727c', 519 519 'conpherence-message-pane-css' => '44154798', 520 520 'conpherence-notification-css' => '04a6e10a', 521 521 'conpherence-thread-manager' => 'bb928342',
+6 -4
src/applications/conpherence/view/ConpherenceThreadListView.php
··· 111 111 array(), 112 112 array( 113 113 id(new PHUIIconView()) 114 - ->addClass('mmr') 114 + ->addClass('msr') 115 115 ->setIconFont($thread->getPolicyIconName($policy_objects)), 116 116 $data['title'], 117 117 )); ··· 188 188 $menu->addMenuItem($item); 189 189 } 190 190 191 - $header = $this->renderMenuItemHeader(pht('Messages')); 191 + $header = $this->renderMenuItemHeader( 192 + pht('Messages'), 'conpherence-message-list-header'); 192 193 $menu->addMenuItem($header); 193 194 194 195 foreach ($conpherences as $conpherence) { ··· 208 209 return $menu; 209 210 } 210 211 211 - private function renderMenuItemHeader($title) { 212 + private function renderMenuItemHeader($title, $class = null) { 212 213 $item = id(new PHUIListItemView()) 213 214 ->setType(PHUIListItemView::TYPE_LABEL) 214 - ->setName($title); 215 + ->setName($title) 216 + ->addClass($class); 215 217 return $item; 216 218 } 217 219
+13 -5
webroot/rsrc/css/application/conpherence/menu.css
··· 44 44 } 45 45 46 46 .conpherence-menu-pane.phabricator-side-menu .phui-list-item-type-label { 47 - padding: 8px 0 6px 8px; 47 + padding: 10px 0 9px 8px; 48 + } 49 + 50 + .conpherence-menu-pane .conpherence-message-list-header { 51 + margin-top: 12px; 48 52 } 49 53 50 54 .device-desktop .conpherence-layout .conpherence-menu-pane { ··· 93 97 94 98 .conpherence-menu .conpherence-menu-item-view { 95 99 display: block; 96 - height: 38px; 100 + height: 36px; 97 101 overflow: hidden; 98 102 position: relative; 99 103 text-decoration: none; ··· 105 109 border-left: 3px solid {$sky}; 106 110 } 107 111 112 + .conpherence-menu .phui-list-item-type-link .phui-list-item-href { 113 + padding: 8px 0 8px 8px; 114 + } 115 + 108 116 .device-desktop .conpherence-menu 109 117 .conpherence-selected.conpherence-menu-item-view:hover { 110 118 background-color: {$hoverselectedgrey}; ··· 119 127 } 120 128 121 129 .conpherence-menu .conpherence-menu-item-view .conpherence-menu-item-image { 122 - top: 5px; 130 + top: 4px; 123 131 left: 6px; 124 132 display: block; 125 133 position: absolute; ··· 131 139 132 140 .conpherence-menu .conpherence-menu-item-view .conpherence-menu-item-title { 133 141 display: block; 134 - margin-top: 10px; 142 + margin-top: 9px; 135 143 margin-left: 40px; 136 144 text-align: left; 137 145 font-weight: bold; ··· 151 159 .conpherence-menu-item-unread-count { 152 160 position: absolute; 153 161 right: 4px; 154 - top: 11px; 162 + top: 10px; 155 163 background: {$blue}; 156 164 border-radius: 2px; 157 165 color: #fff;