@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix a race condition with the chat column
Summary:
Ref T7062. When we load a thread, we always show the column, even if it has been closed between the time we sent the request and when we're processing the response.
Normally this isn't a big deal, but it can specifically show up on mobile.
(This load also shouldn't be happening at all, but I'll fix that separately.)
Test Plan: Mobile no longer shows the column after it loads.
Reviewers: btrahan, chad
Reviewed By: chad
Subscribers: epriestley
Maniphest Tasks: T7062
Differential Revision: https://secure.phabricator.com/D12195
+17
-13
+12
-12
resources/celerity/map.php
+12
-12
resources/celerity/map.php
···
354
354
'rsrc/js/application/auth/behavior-persona-login.js' => '9414ff18',
355
355
'rsrc/js/application/config/behavior-reorder-fields.js' => '14a827de',
356
356
'rsrc/js/application/conpherence/ConpherenceThreadManager.js' => 'bb928342',
357
-
'rsrc/js/application/conpherence/behavior-durable-column.js' => '89fc9db0',
357
+
'rsrc/js/application/conpherence/behavior-durable-column.js' => 'cccebf26',
358
358
'rsrc/js/application/conpherence/behavior-menu.js' => 'de5579b4',
359
359
'rsrc/js/application/conpherence/behavior-pontificate.js' => '21ba5861',
360
360
'rsrc/js/application/conpherence/behavior-quicksand-blacklist.js' => '7927a7d3',
···
584
584
'javelin-behavior-diffusion-locate-file' => '6d3e1947',
585
585
'javelin-behavior-diffusion-pull-lastmodified' => '2b228192',
586
586
'javelin-behavior-doorkeeper-tag' => 'e5822781',
587
-
'javelin-behavior-durable-column' => '89fc9db0',
587
+
'javelin-behavior-durable-column' => 'cccebf26',
588
588
'javelin-behavior-error-log' => '6882e80a',
589
589
'javelin-behavior-fancy-datepicker' => 'c51ae228',
590
590
'javelin-behavior-global-drag-and-drop' => 'bbdf75ca',
···
1494
1494
'javelin-dom',
1495
1495
'javelin-vector',
1496
1496
),
1497
-
'89fc9db0' => array(
1498
-
'javelin-behavior',
1499
-
'javelin-dom',
1500
-
'javelin-stratcom',
1501
-
'javelin-behavior-device',
1502
-
'javelin-scrollbar',
1503
-
'javelin-quicksand',
1504
-
'phabricator-keyboard-shortcut',
1505
-
'conpherence-thread-manager',
1506
-
),
1507
1497
'8a41885b' => array(
1508
1498
'javelin-install',
1509
1499
'javelin-dom',
···
1759
1749
'javelin-dom',
1760
1750
'javelin-stratcom',
1761
1751
'phabricator-phtize',
1752
+
),
1753
+
'cccebf26' => array(
1754
+
'javelin-behavior',
1755
+
'javelin-dom',
1756
+
'javelin-stratcom',
1757
+
'javelin-behavior-device',
1758
+
'javelin-scrollbar',
1759
+
'javelin-quicksand',
1760
+
'phabricator-keyboard-shortcut',
1761
+
'conpherence-thread-manager',
1762
1762
),
1763
1763
'd19198c8' => array(
1764
1764
'javelin-install',
+5
-1
webroot/rsrc/js/application/conpherence/behavior-durable-column.js
+5
-1
webroot/rsrc/js/application/conpherence/behavior-durable-column.js
···
119
119
var column = _getColumnNode();
120
120
var new_column = JX.$H(r.content);
121
121
JX.DOM.replace(column, new_column);
122
-
JX.DOM.show(_getColumnNode());
122
+
if (show) {
123
+
JX.DOM.show(_getColumnNode());
124
+
} else {
125
+
JX.DOM.hide(_getColumnNode());
126
+
}
123
127
var messages = _getColumnMessagesNode();
124
128
scrollbar = new JX.Scrollbar(_getColumnScrollNode());
125
129
scrollbar.scrollTo(messages.scrollHeight);