recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Add the Jxxx Monogram to Phame Post Tab Titles for logged-in users

Summary:
This revision brings Phame Posts inline with other objects like Tasks, Revisions, Passphrase, etc. which all place the Monogram into the browser tab title

This improves useability of Phame Posts by making it easier to reference them in other parts of Phorge

**Old Look**
{F22364 size=full}

**New Look**
{F22365 size=full}

Test Plan:
Made a post, be logged-in, saw the Monogram in the title (as usual in other apps like Maniphest).

See same post as logged-out (or be a search engine), saw just the title (so your SEO consultant is still happy).

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: Cigaryno, bekay, speck, tobiaswiese, valerio.bozzolan

Tags: #phame

Maniphest Tasks: T15050

Differential Revision: https://we.phorge.it/D25022

ekubischta 1552925d 5bd99a39

+8 -1
+8 -1
src/applications/phame/controller/post/PhamePostViewController.php
··· 163 163 $prev->getBestURI($is_live, $is_external)); 164 164 } 165 165 166 + $monogram = $post->getMonogram(); 167 + 166 168 $document->setFoot($next_view); 167 169 $crumbs = $this->buildApplicationCrumbs(); 168 170 $properties = phutil_tag_div('phui-document-view-pro-box', $properties); 169 171 172 + // Public viewers like search engines will not see the monogram 173 + $title = $viewer->isLoggedIn() 174 + ? pht('%s %s', $monogram, $post->getTitle()) 175 + : $post->getTitle(); 176 + 170 177 $page = $this->newPage() 171 - ->setTitle($post->getTitle()) 178 + ->setTitle($title) 172 179 ->setPageObjectPHIDs(array($post->getPHID())) 173 180 ->setCrumbs($crumbs) 174 181 ->appendChild(