recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

In Differential, render status for any active Drydock repository operation, not just "Land" operations

Summary:
See PHI18. Third parties can currently define other types of Drydock operations (like "Merge Check" or "Cherry-Pick") but we won't show them in the UI.

This is a simple change which improves third-party support for now. These kinds of operations generally make sense in the upstream, but the pathways to support are longer.

Test Plan:
- Verified that there are no other types of repository operation which we'd want to exclude in the upstream today by reviewing the "Repository Operation" subclasses.
- Will click some buttons in production to make sure this works.

Reviewers: chad

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D18276

epriestley 1588d3e2 c217d761

+4 -4
+4 -4
src/applications/differential/controller/DifferentialRevisionViewController.php
··· 1051 1051 return null; 1052 1052 } 1053 1053 1054 + // NOTE: The upstream currently supports only "Land" operations, but 1055 + // third parties have other operations (see PHI18). For now, we show any 1056 + // operation that exists. We'll refine this in the future. 1057 + 1054 1058 $operations = id(new DrydockRepositoryOperationQuery()) 1055 1059 ->setViewer($viewer) 1056 1060 ->withObjectPHIDs(array($revision->getPHID())) 1057 1061 ->withIsDismissed(false) 1058 - ->withOperationTypes( 1059 - array( 1060 - DrydockLandRepositoryOperation::OPCONST, 1061 - )) 1062 1062 ->execute(); 1063 1063 if (!$operations) { 1064 1064 return null;