@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Remove a check for a non-existing array offset
Summary:
```
$attrs = array('title' => $file);
if (empty($attrs['href'])) {
```
makes no sense. Offset `'href'` on array `$attrs` never exists since the removal of the try/catch block in rPbe5b8968.
Test Plan: Read the code.
Reviewers: O1 Blessed Committers, avivey
Reviewed By: O1 Blessed Committers, avivey
Subscribers: avivey, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno
Differential Revision: https://we.phorge.it/D26505
+4
-6
+4
-6
src/view/widget/AphrontStackTraceView.php
+4
-6
src/view/widget/AphrontStackTraceView.php
···
50
50
if ($file) {
51
51
if (isset($callsigns[$lib])) {
52
52
$attrs = array('title' => $file);
53
-
if (empty($attrs['href'])) {
54
-
$attrs['href'] = sprintf($path, $callsigns[$lib]).
55
-
str_replace(DIRECTORY_SEPARATOR, '/', $relative).
56
-
'$'.$part['line'];
57
-
$attrs['target'] = '_blank';
58
-
}
53
+
$attrs['href'] = sprintf($path, $callsigns[$lib]).
54
+
str_replace(DIRECTORY_SEPARATOR, '/', $relative).
55
+
'$'.$part['line'];
56
+
$attrs['target'] = '_blank';
59
57
$file_name = phutil_tag(
60
58
'a',
61
59
$attrs,