recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Expose previous names of renamed users to admins only

Summary:
Restrict exposure of the previous username(s) of a renamed user to Phorge admins only. The previous username is not of particular interest to most users, and dropping the previous username from the public UI reduces the chances of deadnaming.

Closes T16276

Test Plan:
* As an admin, rename a user account several times.
* Look at the entries on http://phorge.localhost/feed/ as an admin (no changes) and as an average user (old names not shown).
* Look at the entries on http://phorge.localhost/people/manage/2/ as an admin (no changes) and as an average user (old names not shown).

Reviewers: O1 Blessed Committers, mainframe98

Reviewed By: O1 Blessed Committers, mainframe98

Subscribers: mainframe98, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T16276

Differential Revision: https://we.phorge.it/D26366

Andre Klapper 15cbbce3 cd4dd3b3

+11
+11
src/applications/people/xaction/PhabricatorUserUsernameTransaction.php
··· 37 37 } 38 38 39 39 public function getTitle() { 40 + if (!$this->getViewer()->getIsAdmin()) { 41 + return pht( 42 + '%s renamed this user.', 43 + $this->renderAuthor()); 44 + } 40 45 return pht( 41 46 '%s renamed this user from %s to %s.', 42 47 $this->renderAuthor(), ··· 45 50 } 46 51 47 52 public function getTitleForFeed() { 53 + if (!$this->getViewer()->getIsAdmin()) { 54 + return pht( 55 + '%s renamed %s.', 56 + $this->renderAuthor(), 57 + $this->renderObject()); 58 + } 48 59 return pht( 49 60 '%s renamed %s from %s to %s.', 50 61 $this->renderAuthor(),