recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

PHP 8.5: Repository creation: Gracefully handle missing VCS parameter

Summary:
Setting null as an array key is deprecated since PHP 8.5 per https://www.php.net/releases/8.5/en.php: "Using null as an array offset or when calling array_key_exists() is now deprecated. Use an empty string instead."

```
ERROR 8192: Using null as an array offset is deprecated, use an empty string instead at [/var/www/html/phorge/phorge/src/applications/diffusion/controller/DiffusionRepositoryEditController.php:17]
```

Closes T16406

Test Plan: Go to http://phorge.localhost/diffusion/edit/form/default/ on PHP 8.5

Reviewers: O1 Blessed Committers, mainframe98

Reviewed By: O1 Blessed Committers, mainframe98

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T16406

Differential Revision: https://we.phorge.it/D26603

Andre Klapper 17247f56 d5faf6fa

+1 -1
+1 -1
src/applications/diffusion/controller/DiffusionRepositoryEditController.php
··· 14 14 15 15 $vcs = $request->getStr('vcs'); 16 16 $vcs_types = PhabricatorRepositoryType::getRepositoryTypeMap(); 17 - if (empty($vcs_types[$vcs])) { 17 + if (!$vcs || empty($vcs_types[$vcs])) { 18 18 return $this->buildVCSTypeResponse(); 19 19 } 20 20