recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix PHP 8.1 "strlen(null)" exceptions editing existing Dashboard query panel with no query defined

Summary:
`strlen()` was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

```
ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/dashboard/editfield/PhabricatorDashboardQueryPanelQueryEditField.php:41]
```

```
ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/dashboard/editfield/PhabricatorDashboardQueryPanelQueryEditField.php:59]
```

Closes T15791

Test Plan: Successfully create a Dashboard query panel searching for "Diffusion Raw Commits" (which has no Query defined per T15790) and try to edit it afterwards under PHP 8.1 or later.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15791

Differential Revision: https://we.phorge.it/D25596

Andre Klapper 17b568b9 3349c3be

+2 -2
+2 -2
src/applications/dashboard/editfield/PhabricatorDashboardQueryPanelQueryEditField.php
··· 38 38 } 39 39 } 40 40 41 - if (strlen($value) && !$seen) { 41 + if (phutil_nonempty_string($value) && !$seen) { 42 42 $name = pht('Custom Query ("%s")', $value); 43 43 } else { 44 44 $name = pht('(None)'); ··· 56 56 'queryID' => $control_id, 57 57 'options' => $queries, 58 58 'value' => array( 59 - 'key' => strlen($value) ? $value : null, 59 + 'key' => phutil_nonempty_string($value) ? $value : null, 60 60 'name' => $name, 61 61 ), 62 62 ));