recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Ponder: Do not offer/default to current status in Change Question Status

Summary:
The user intention is to change the question status, so listing and defaulting to the current status makes no sense. Remove the current status from the list of available options.

Also, the sidebar entry names "Close Question" and "Reopen Question" are misleading as the resulting dialog allows changing the question status from Closed from Closed. Replace that with a generic "Change Question Status" menu entry.

Closes T16443

Test Plan: Go to a Ponder Question, look at the second option in the sidebar menu, select it, look at the available list options, change the question status.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T16443

Differential Revision: https://we.phorge.it/D26645

Andre Klapper 187ed0e9 2309ee42

+6 -9
+4 -2
src/applications/ponder/controller/PonderQuestionStatusController.php
··· 42 42 43 43 $radio = id(new AphrontFormRadioButtonControl()) 44 44 ->setLabel(pht('Status')) 45 - ->setName('status') 46 - ->setValue($v_status); 45 + ->setName('status'); 47 46 48 47 foreach (PonderQuestionStatus::getQuestionStatusMap() as $value => $name) { 49 48 $description = PonderQuestionStatus::getQuestionStatusDescription($value); 49 + if ($value === $v_status) { 50 + continue; 51 + } 50 52 $radio->addButton($value, $name, $description); 51 53 } 52 54
+2 -7
src/applications/ponder/controller/PonderQuestionViewController.php
··· 144 144 145 145 $curtain = $this->newCurtainView($question); 146 146 147 - if ($question->getStatus() == PonderQuestionStatus::STATUS_OPEN) { 148 - $name = pht('Close Question'); 149 - $icon = 'fa-check-square-o'; 150 - } else { 151 - $name = pht('Reopen Question'); 152 - $icon = 'fa-square-o'; 153 - } 147 + $name = pht('Change Question Status'); 148 + $icon = 'fa-square-o'; 154 149 155 150 $curtain->addAction( 156 151 id(new PhabricatorActionView())