@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix duplicating panel when editing in column 2
Summary: Fixes T10612. We're writing a new panel to any dashboard even if it already exists. No need when just updating a panel title.
Test Plan: Add "welcome" panel to column 2 of a clean dashboard. Edit title, save. See correct panel in correct place.
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Maniphest Tasks: T10612
Differential Revision: https://secure.phabricator.com/D17349
authored by
Chad Little
and committed by
chad
1cb924ce
f9163bf0
+1
-1
+1
-1
src/applications/dashboard/controller/PhabricatorDashboardPanelEditController.php
+1
-1
src/applications/dashboard/controller/PhabricatorDashboardPanelEditController.php
···
143
143
->applyTransactions($panel, $xactions);
144
144
145
145
// If we're creating a panel directly on a dashboard, add it now.
146
-
if ($dashboard) {
146
+
if ($dashboard && $is_create) {
147
147
PhabricatorDashboardTransactionEditor::addPanelToDashboard(
148
148
$viewer,
149
149
PhabricatorContentSource::newFromRequest($request),