@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
PHPDoc: Replace non-existing return type exit with never-returns
Summary:
`exit` is not a valid @return type in PHPDoc per https://docs.phpdoc.org/guide/references/phpdoc/types.html.
Go for `never-returns` which seems the best compromise according to https://phpstan.org/writing-php-code/phpdoc-types#bottom-type and https://stackoverflow.com/questions/31672862/phpdoc-function-exits
Test Plan: Read the code.
Reviewers: O1 Blessed Committers, valerio.bozzolan
Reviewed By: O1 Blessed Committers, valerio.bozzolan
Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno
Differential Revision: https://we.phorge.it/D26096
+2
-2
+2
-2
support/startup/PhabricatorStartup.php
+2
-2
support/startup/PhabricatorStartup.php
···
348
348
* error log. If not provided, the client message is used.
349
349
* You can pass a more detailed message here (e.g., with
350
350
* stack traces) to avoid showing it to users.
351
-
* @return exit This method **does not return**.
351
+
* @return never-returns This method **does not return**.
352
352
*
353
353
* @task apocalypse
354
354
*/
···
722
722
* Emit an HTTP 429 "Too Many Requests" response (indicating that the user
723
723
* has exceeded application rate limits) and exit.
724
724
*
725
-
* @return exit This method **does not return**.
725
+
* @return never-returns This method **does not return**.
726
726
* @task ratelimit
727
727
*/
728
728
private static function didRateLimit($reason) {