recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix a possible `count(null)` in PHUIInfoView

Summary:
See <https://discourse.phabricator-community.org/t/php7-2-exception-count-parameter-must-be-an-array-or-an-object-that-implements-countable/1031>.

PHP7.2 raises a warning about `count(scalar)` (GREAT!) and we have one here if the caller doesn't `setErrors(...)`.

Test Plan: Sanity-checked usage of `$this->errors`.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D18964

epriestley 1db281bc 40e9806e

+1 -1
+1 -1
src/view/phui/PHUIInfoView.php
··· 10 10 const SEVERITY_PLAIN = 'plain'; 11 11 12 12 private $title; 13 - private $errors; 13 + private $errors = array(); 14 14 private $severity = null; 15 15 private $id; 16 16 private $buttons = array();