@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Modernize Owners a bit
Summary: Update Owners per current UI standards, add crumbs at each level, removed AphrontPanels, check spacing.
Test Plan: Tested a list of owner packages, editing a package, creating a package, and various filters.
Reviewers: btrahan, epriestley
Reviewed By: epriestley
Subscribers: Korvin, epriestley
Differential Revision: https://secure.phabricator.com/D11961
+55
-46
+6
-5
src/applications/owners/controller/PhabricatorOwnersController.php
+6
-5
src/applications/owners/controller/PhabricatorOwnersController.php
···
44
44
break;
45
45
}
46
46
47
-
$crumbs = $this->buildApplicationCrumbs();
48
-
$crumbs->addTextCrumb($title);
47
+
return $nav;
48
+
}
49
+
50
+
protected function buildApplicationCrumbs() {
51
+
$crumbs = parent::buildApplicationCrumbs();
49
52
50
53
$crumbs->addAction(
51
54
id(new PHUIListItemView())
···
53
56
->setHref('/owners/new/')
54
57
->setIcon('fa-plus-square'));
55
58
56
-
$nav->setCrumbs($crumbs);
57
-
58
-
return $nav;
59
+
return $crumbs;
59
60
}
60
61
61
62
public function buildApplicationMenu() {
+31
-34
src/applications/owners/controller/PhabricatorOwnersDetailController.php
+31
-34
src/applications/owners/controller/PhabricatorOwnersDetailController.php
···
111
111
'wide',
112
112
));
113
113
114
-
$panel = new AphrontPanelView();
115
-
$panel->setNoBackground();
116
-
$panel->setHeader(
114
+
$panel = new PHUIObjectBoxView();
115
+
$header = new PHUIHeaderView();
116
+
$header->setHeader(
117
117
pht('Package Details for "%s"', $package->getName()));
118
-
$panel->addButton(
119
-
javelin_tag(
120
-
'a',
121
-
array(
122
-
'href' => '/owners/delete/'.$package->getID().'/',
123
-
'class' => 'button grey',
124
-
'sigil' => 'workflow',
125
-
),
126
-
pht('Delete Package')));
127
-
$panel->addButton(
128
-
phutil_tag(
129
-
'a',
130
-
array(
131
-
'href' => '/owners/edit/'.$package->getID().'/',
132
-
'class' => 'button',
133
-
),
134
-
pht('Edit Package')));
118
+
$header->addActionLink(
119
+
id(new PHUIButtonView())
120
+
->setTag('a')
121
+
->setHref('/owners/delete/'.$package->getID().'/')
122
+
->addSigil('workflow')
123
+
->setText(pht('Delete Package')));
124
+
125
+
$header->addActionLink(
126
+
id(new PHUIButtonView())
127
+
->setTag('a')
128
+
->setHref('/owners/edit/'.$package->getID().'/')
129
+
->setText(pht('Edit Package')));
130
+
131
+
$panel->setHeader($header);
135
132
$panel->appendChild($table);
136
133
137
134
$key = 'package/'.$package->getID();
···
185
182
$commit_views[] = array(
186
183
'view' => $view,
187
184
'header' => pht('Recent Commits in Package'),
188
-
'button' => phutil_tag(
189
-
'a',
190
-
array(
191
-
'href' => $commit_uri,
192
-
'class' => 'button grey',
193
-
),
194
-
pht('View All Package Commits')),
185
+
'button' => id(new PHUIButtonView())
186
+
->setTag('a')
187
+
->setHref($commit_uri)
188
+
->setText(pht('View All Package Commits')),
195
189
);
196
190
197
191
$phids = array();
···
203
197
204
198
$commit_panels = array();
205
199
foreach ($commit_views as $commit_view) {
206
-
$commit_panel = new AphrontPanelView();
207
-
$commit_panel->setNoBackground();
208
-
$commit_panel->setHeader($commit_view['header']);
200
+
$commit_panel = new PHUIObjectBoxView();
201
+
$header = new PHUIHeaderView();
202
+
$header->setHeader($commit_view['header']);
209
203
if (isset($commit_view['button'])) {
210
-
$commit_panel->addButton($commit_view['button']);
204
+
$header->addActionLink($commit_view['button']);
211
205
}
212
206
$commit_view['view']->setHandles($handles);
207
+
$commit_panel->setHeader($header);
213
208
$commit_panel->appendChild($commit_view['view']);
214
209
215
210
$commit_panels[] = $commit_panel;
216
211
}
217
212
213
+
$crumbs = $this->buildApplicationCrumbs();
214
+
$crumbs->addTextCrumb($package->getName());
215
+
218
216
$nav = $this->buildSideNavView();
217
+
$nav->appendChild($crumbs);
219
218
$nav->appendChild($panel);
220
219
$nav->appendChild($commit_panels);
221
220
222
221
return $this->buildApplicationPage(
223
-
array(
224
-
$nav,
225
-
),
222
+
$nav,
226
223
array(
227
224
'title' => pht('Package %s', $package->getName()),
228
225
));
+8
src/applications/owners/controller/PhabricatorOwnersEditController.php
+8
src/applications/owners/controller/PhabricatorOwnersEditController.php
···
251
251
->setFormErrors($errors)
252
252
->setForm($form);
253
253
254
+
$crumbs = $this->buildApplicationCrumbs();
255
+
if ($package->getID()) {
256
+
$crumbs->addTextCrumb(pht('Edit %s', $package->getName()));
257
+
} else {
258
+
$crumbs->addTextCrumb(pht('New Package'));
259
+
}
260
+
254
261
$nav = $this->buildSideNavView();
262
+
$nav->appendChild($crumbs);
255
263
$nav->appendChild($form_box);
256
264
257
265
return $this->buildApplicationPage(
+10
-7
src/applications/owners/controller/PhabricatorOwnersListController.php
+10
-7
src/applications/owners/controller/PhabricatorOwnersListController.php
···
130
130
}
131
131
$packages = $package->loadAllFromArray($data);
132
132
133
-
$header = pht('Owned Packages');
133
+
$header = pht('Project Packages');
134
134
$nodata = pht('No owned packages');
135
135
break;
136
136
case 'all':
···
198
198
->setValue(pht('Search for Packages')));
199
199
200
200
$filter->appendChild($form);
201
+
$title = pht('Package Index');
202
+
203
+
$crumbs = $this->buildApplicationCrumbs();
204
+
$crumbs->addTextCrumb($header);
205
+
$crumbs->setBorder(true);
201
206
202
207
$nav = $this->buildSideNavView();
208
+
$nav->appendChild($crumbs);
203
209
$nav->appendChild($filter);
204
210
$nav->appendChild($content);
205
211
206
212
return $this->buildApplicationPage(
207
-
array(
208
-
$nav,
209
-
),
213
+
$nav,
210
214
array(
211
215
'title' => pht('Package Index'),
212
216
));
···
330
334
'narrow',
331
335
));
332
336
333
-
$panel = new AphrontPanelView();
334
-
$panel->setHeader($header);
337
+
$panel = new PHUIObjectBoxView();
338
+
$panel->setHeaderText($header);
335
339
$panel->appendChild($table);
336
-
$panel->setNoBackground();
337
340
338
341
return $panel;
339
342
}