+4 -4

src/__phutil_library_map__.php

reviewed

··· 1989 1989 'PhabricatorObjectListQueryTestCase' => 'applications/phid/query/__tests__/PhabricatorObjectListQueryTestCase.php', 1990 1990 'PhabricatorObjectMailReceiver' => 'applications/metamta/receiver/PhabricatorObjectMailReceiver.php', 1991 1991 'PhabricatorObjectMailReceiverTestCase' => 'applications/metamta/receiver/__tests__/PhabricatorObjectMailReceiverTestCase.php', 1992 1992 - 'PhabricatorObjectMentionedByObject' => 'applications/transactions/edges/PhabricatorObjectMentionedByObject.php', 1993 1993 - 'PhabricatorObjectMentionsObject' => 'applications/transactions/edges/PhabricatorObjectMentionsObject.php', 1992 1992 + 'PhabricatorObjectMentionedByObjectEdgeType' => 'applications/transactions/edges/PhabricatorObjectMentionedByObjectEdgeType.php', 1993 1993 + 'PhabricatorObjectMentionsObjectEdgeType' => 'applications/transactions/edges/PhabricatorObjectMentionsObjectEdgeType.php', 1994 1994 'PhabricatorObjectQuery' => 'applications/phid/query/PhabricatorObjectQuery.php', 1995 1995 'PhabricatorObjectRemarkupRule' => 'infrastructure/markup/rule/PhabricatorObjectRemarkupRule.php', 1996 1996 'PhabricatorObjectSelectorDialog' => 'view/control/PhabricatorObjectSelectorDialog.php', ··· 5162 5162 'PhabricatorObjectListQueryTestCase' => 'PhabricatorTestCase', 5163 5163 'PhabricatorObjectMailReceiver' => 'PhabricatorMailReceiver', 5164 5164 'PhabricatorObjectMailReceiverTestCase' => 'PhabricatorTestCase', 5165 5165 - 'PhabricatorObjectMentionedByObject' => 'PhabricatorEdgeType', 5166 5166 - 'PhabricatorObjectMentionsObject' => 'PhabricatorEdgeType', 5165 5165 + 'PhabricatorObjectMentionedByObjectEdgeType' => 'PhabricatorEdgeType', 5166 5166 + 'PhabricatorObjectMentionsObjectEdgeType' => 'PhabricatorEdgeType', 5167 5167 'PhabricatorObjectQuery' => 'PhabricatorCursorPagedPolicyAwareQuery', 5168 5168 'PhabricatorObjectRemarkupRule' => 'PhutilRemarkupRule', 5169 5169 'PhabricatorOffsetPagedQuery' => 'PhabricatorQuery',

+3 -2

src/applications/transactions/edges/PhabricatorObjectMentionedByObject.php src/applications/transactions/edges/PhabricatorObjectMentionedByObjectEdgeType.php

reviewed

··· 1 1 <?php 2 2 3 3 - final class PhabricatorObjectMentionedByObject extends PhabricatorEdgeType { 3 3 + final class PhabricatorObjectMentionedByObjectEdgeType 4 4 + extends PhabricatorEdgeType { 4 5 5 6 const EDGECONST = 51; 6 7 7 8 public function getInverseEdgeConstant() { 8 8 - return PhabricatorObjectMentionsObject::EDGECONST; 9 9 + return PhabricatorObjectMentionsObjectEdgeType::EDGECONST; 9 10 } 10 11 11 12 public function shouldWriteInverseTransactions() {

-15

src/applications/transactions/edges/PhabricatorObjectMentionsObject.php

reviewed

··· 1 1 - <?php 2 2 - 3 3 - final class PhabricatorObjectMentionsObject extends PhabricatorEdgeType { 4 4 - 5 5 - const EDGECONST = 52; 6 6 - 7 7 - public function getInverseEdgeConstant() { 8 8 - return PhabricatorObjectMentionedByObject::EDGECONST; 9 9 - } 10 10 - 11 11 - public function shouldWriteInverseTransactions() { 12 12 - return true; 13 13 - } 14 14 - 15 15 - }

+16

src/applications/transactions/edges/PhabricatorObjectMentionsObjectEdgeType.php

reviewed

··· 1 1 + <?php 2 2 + 3 3 + final class PhabricatorObjectMentionsObjectEdgeType 4 4 + extends PhabricatorEdgeType { 5 5 + 6 6 + const EDGECONST = 52; 7 7 + 8 8 + public function getInverseEdgeConstant() { 9 9 + return PhabricatorObjectMentionedByObjectEdgeType::EDGECONST; 10 10 + } 11 11 + 12 12 + public function shouldWriteInverseTransactions() { 13 13 + return true; 14 14 + } 15 15 + 16 16 + }

+1 -1

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

reviewed

··· 1249 1249 } 1250 1250 } 1251 1251 if ($mentionable_phids) { 1252 1252 - $edge_type = PhabricatorObjectMentionsObject::EDGECONST; 1252 1252 + $edge_type = PhabricatorObjectMentionsObjectEdgeType::EDGECONST; 1253 1253 $block_xactions[] = newv(get_class(head($xactions)), array()) 1254 1254 ->setIgnoreOnNoEffect(true) 1255 1255 ->setTransactionType(PhabricatorTransactions::TYPE_EDGE)

+6 -6

src/applications/transactions/storage/PhabricatorApplicationTransaction.php

reviewed

··· 452 452 case PhabricatorTransactions::TYPE_EDGE: 453 453 $edge_type = $this->getMetadataValue('edge:type'); 454 454 switch ($edge_type) { 455 455 - case PhabricatorObjectMentionsObject::EDGECONST: 455 455 + case PhabricatorObjectMentionsObjectEdgeType::EDGECONST: 456 456 return true; 457 457 break; 458 458 - case PhabricatorObjectMentionedByObject::EDGECONST: 458 458 + case PhabricatorObjectMentionedByObjectEdgeType::EDGECONST: 459 459 $new = ipull($this->getNewValue(), 'dst'); 460 460 $old = ipull($this->getOldValue(), 'dst'); 461 461 $add = array_diff($new, $old); ··· 491 491 case PhabricatorTransactions::TYPE_EDGE: 492 492 $edge_type = $this->getMetadataValue('edge:type'); 493 493 switch ($edge_type) { 494 494 - case PhabricatorObjectMentionsObject::EDGECONST: 495 495 - case PhabricatorObjectMentionedByObject::EDGECONST: 494 494 + case PhabricatorObjectMentionsObjectEdgeType::EDGECONST: 495 495 + case PhabricatorObjectMentionedByObjectEdgeType::EDGECONST: 496 496 return true; 497 497 break; 498 498 default: ··· 521 521 case PhabricatorTransactions::TYPE_EDGE: 522 522 $edge_type = $this->getMetadataValue('edge:type'); 523 523 switch ($edge_type) { 524 524 - case PhabricatorObjectMentionsObject::EDGECONST: 525 525 - case PhabricatorObjectMentionedByObject::EDGECONST: 524 524 + case PhabricatorObjectMentionsObjectEdgeType::EDGECONST: 525 525 + case PhabricatorObjectMentionedByObjectEdgeType::EDGECONST: 526 526 return true; 527 527 break; 528 528 default: