@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Apply reviewer changes from Herald via ModularTransactions
Summary:
Ref T10967. This converts the reviewer update action in Herald from an older edge write to a newer ModularTransactions write.
The major value from this is that we get a double-write to the new reviewers table.
Test Plan:
- Wrote a Herald rule to add a reviewer and a blocking reviewer.
- Saw them added properly to a revision with: no reviewers; both as blocking; A as blocking, B as nonblocking; A as nonblocking, B as blocking.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T10967
Differential Revision: https://secure.phabricator.com/D17511
+7
-8
+7
-8
src/applications/differential/herald/DifferentialReviewersHeraldAction.php
+7
-8
src/applications/differential/herald/DifferentialReviewersHeraldAction.php
···
81
81
82
82
$value = array();
83
83
foreach ($phids as $phid) {
84
-
$value[$phid] = array(
85
-
'data' => array(
86
-
'status' => $new_status,
87
-
),
88
-
);
84
+
if ($is_blocking) {
85
+
$value[] = 'blocking('.$phid.')';
86
+
} else {
87
+
$value[] = $phid;
88
+
}
89
89
}
90
90
91
-
$edgetype_reviewer = DifferentialRevisionHasReviewerEdgeType::EDGECONST;
91
+
$reviewers_type = DifferentialRevisionReviewersTransaction::TRANSACTIONTYPE;
92
92
93
93
$xaction = $adapter->newTransaction()
94
-
->setTransactionType(PhabricatorTransactions::TYPE_EDGE)
95
-
->setMetadataValue('edge:type', $edgetype_reviewer)
94
+
->setTransactionType($reviewers_type)
96
95
->setNewValue(
97
96
array(
98
97
'+' => $value,