@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Swap Maniphest edit writes to new transactions
Summary: Ref T2217. This is essentially the last writer, should be able to start deleting code now.
Test Plan: Used "Edit Task" to make a bunch of task edits.
Reviewers: btrahan, garoevans
Reviewed By: garoevans
CC: aran
Maniphest Tasks: T2217
Differential Revision: https://secure.phabricator.com/D7090
+7
-7
+6
-7
src/applications/maniphest/controller/ManiphestTaskEditController.php
+6
-7
src/applications/maniphest/controller/ManiphestTaskEditController.php
···
210
210
'ip' => $request->getRemoteAddr(),
211
211
));
212
212
213
-
$template = new ManiphestTransaction();
214
-
$template->setAuthorPHID($user->getPHID());
215
-
$template->setContentSource($content_source);
213
+
$template = new ManiphestTransactionPro();
216
214
$transactions = array();
217
215
218
216
foreach ($changes as $type => $value) {
···
265
263
$task = $event->getValue('task');
266
264
$transactions = $event->getValue('transactions');
267
265
268
-
$editor = new ManiphestTransactionEditor();
269
-
$editor->setActor($user);
270
-
$editor->setAuxiliaryFields($aux_fields);
271
-
$editor->applyTransactions($task, $transactions);
266
+
$editor = id(new ManiphestTransactionEditorPro())
267
+
->setActor($user)
268
+
->setContentSourceFromRequest($request)
269
+
->setContinueOnNoEffect(true)
270
+
->applyTransactions($task, $transactions);
272
271
273
272
$event = new PhabricatorEvent(
274
273
PhabricatorEventType::TYPE_MANIPHEST_DIDEDITTASK,
+1
src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
+1
src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php