@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Remove pointless requireCapabilities() method from PhabricatorRepositoryEditor
Summary: Depends on D19582. Ref T13164. It's not possible to reach the editor without passing through a CAN_EDIT check, and it shouldn't be necessarily to manually specify that edits require CAN_EDIT by default.
Test Plan: Grepped for `RepositoryEditor`, verified that all callsites pass through a CAN_EDIT check.
Reviewers: amckinley
Reviewed By: amckinley
Maniphest Tasks: T13164
Differential Revision: https://secure.phabricator.com/D19583
-34
-34
src/applications/repository/editor/PhabricatorRepositoryEditor.php
-34
src/applications/repository/editor/PhabricatorRepositoryEditor.php
···
236
236
237
237
}
238
238
239
-
protected function requireCapabilities(
240
-
PhabricatorLiskDAO $object,
241
-
PhabricatorApplicationTransaction $xaction) {
242
-
243
-
switch ($xaction->getTransactionType()) {
244
-
case PhabricatorRepositoryTransaction::TYPE_ACTIVATE:
245
-
case PhabricatorRepositoryTransaction::TYPE_NAME:
246
-
case PhabricatorRepositoryTransaction::TYPE_DESCRIPTION:
247
-
case PhabricatorRepositoryTransaction::TYPE_ENCODING:
248
-
case PhabricatorRepositoryTransaction::TYPE_DEFAULT_BRANCH:
249
-
case PhabricatorRepositoryTransaction::TYPE_TRACK_ONLY:
250
-
case PhabricatorRepositoryTransaction::TYPE_AUTOCLOSE_ONLY:
251
-
case PhabricatorRepositoryTransaction::TYPE_UUID:
252
-
case PhabricatorRepositoryTransaction::TYPE_SVN_SUBPATH:
253
-
case PhabricatorRepositoryTransaction::TYPE_VCS:
254
-
case PhabricatorRepositoryTransaction::TYPE_NOTIFY:
255
-
case PhabricatorRepositoryTransaction::TYPE_AUTOCLOSE:
256
-
case PhabricatorRepositoryTransaction::TYPE_PUSH_POLICY:
257
-
case PhabricatorRepositoryTransaction::TYPE_DANGEROUS:
258
-
case PhabricatorRepositoryTransaction::TYPE_ENORMOUS:
259
-
case PhabricatorRepositoryTransaction::TYPE_SLUG:
260
-
case PhabricatorRepositoryTransaction::TYPE_SERVICE:
261
-
case PhabricatorRepositoryTransaction::TYPE_SYMBOLS_SOURCES:
262
-
case PhabricatorRepositoryTransaction::TYPE_SYMBOLS_LANGUAGE:
263
-
case PhabricatorRepositoryTransaction::TYPE_STAGING_URI:
264
-
case PhabricatorRepositoryTransaction::TYPE_AUTOMATION_BLUEPRINTS:
265
-
PhabricatorPolicyFilter::requireCapability(
266
-
$this->requireActor(),
267
-
$object,
268
-
PhabricatorPolicyCapability::CAN_EDIT);
269
-
break;
270
-
}
271
-
}
272
-
273
239
protected function validateTransaction(
274
240
PhabricatorLiskDAO $object,
275
241
$type,