@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Clean up repositories with symbols correctly
Summary: We currently try to delete symbols by ID, but the table has a multipart primary key and no `id` column.
Test Plan: Ran query locally; had @JThramer verify fix in his environment.
Reviewers: btrahan
Reviewed By: btrahan
CC: JThramer, aran
Differential Revision: https://secure.phabricator.com/D4626
+5
-8
+5
-8
src/applications/repository/storage/PhabricatorRepositoryArcanistProject.php
+5
-8
src/applications/repository/storage/PhabricatorRepositoryArcanistProject.php
···
34
34
35
35
public function delete() {
36
36
$this->openTransaction();
37
-
$conn_w = $this->establishConnection('w');
38
37
39
-
$symbols = id(new PhabricatorRepositorySymbol())->loadAllWhere(
40
-
'arcanistProjectID = %d',
41
-
$this->getID()
42
-
);
43
-
foreach ($symbols as $symbol) {
44
-
$symbol->delete();
45
-
}
38
+
queryfx(
39
+
$this->establishConnection('w'),
40
+
'DELETE FROM %T WHERE arcanistProjectID = %d',
41
+
id(new PhabricatorRepositorySymbol())->getTableName(),
42
+
$this->getID());
46
43
47
44
$result = parent::delete();
48
45
$this->saveTransaction();