@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Update DivinerAtomController for a long-ago change to the docblock parser API
Summary: Ref T13505. See that task for discussion.
Test Plan: Ran `diviner generate` locally, found a page fataling on this `strlen()`, applied patch, got a sketchy but not-broken page.
Maniphest Tasks: T13505
Differential Revision: https://secure.phabricator.com/D21061
+1
-3
+1
-3
src/applications/diviner/controller/DivinerAtomController.php
+1
-3
src/applications/diviner/controller/DivinerAtomController.php
···
435
435
$task_specs = array();
436
436
437
437
$tasks = $symbol->getAtom()->getDocblockMetaValue('task');
438
-
if (strlen($tasks)) {
439
-
$tasks = phutil_split_lines($tasks, $retain_endings = false);
440
-
438
+
if ($tasks) {
441
439
foreach ($tasks as $task) {
442
440
list($name, $title) = explode(' ', $task, 2);
443
441
$name = trim($name);