@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix an issue in the new Harbormaster build log view where clicking the "^" icon doesn't work right

Summary:
Ref T13130. See PHI617.

The new build log UI has tags like `<a href="...">Show More Above <span icon>^</span></a>`. If you click the little "^" icon, the event target is the `<span />` instead of the `<a />` so we expand on the wrong node.

Instead, select the `<a />` by sigil explicitly.

Test Plan: Viewed new log UI in Harbormaster, clicked "^" icon and text, got the same (correct) behavior on both.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13130

Differential Revision: https://secure.phabricator.com/D19410

+6 -6
+5 -5
resources/celerity/map.php
··· 391 391 'rsrc/js/application/files/behavior-document-engine.js' => 'ee0deff8', 392 392 'rsrc/js/application/files/behavior-icon-composer.js' => '8499b6ab', 393 393 'rsrc/js/application/files/behavior-launch-icon-composer.js' => '48086888', 394 - 'rsrc/js/application/harbormaster/behavior-harbormaster-log.js' => '191b4909', 394 + 'rsrc/js/application/harbormaster/behavior-harbormaster-log.js' => '549459b8', 395 395 'rsrc/js/application/herald/HeraldRuleEditor.js' => 'dca75c0e', 396 396 'rsrc/js/application/herald/PathTypeahead.js' => '662e9cea', 397 397 'rsrc/js/application/herald/herald-rule-editor.js' => '7ebaeed3', ··· 609 609 'javelin-behavior-event-all-day' => 'b41537c9', 610 610 'javelin-behavior-fancy-datepicker' => 'ecf4e799', 611 611 'javelin-behavior-global-drag-and-drop' => '960f6a39', 612 - 'javelin-behavior-harbormaster-log' => '191b4909', 612 + 'javelin-behavior-harbormaster-log' => '549459b8', 613 613 'javelin-behavior-herald-rule-editor' => '7ebaeed3', 614 614 'javelin-behavior-high-security-warning' => 'a464fe03', 615 615 'javelin-behavior-history-install' => '7ee2b591', ··· 960 960 '185bbd53' => array( 961 961 'javelin-install', 962 962 ), 963 - '191b4909' => array( 964 - 'javelin-behavior', 965 - ), 966 963 '1ad0a787' => array( 967 964 'javelin-install', 968 965 'javelin-reactor', ··· 1256 1253 'javelin-stratcom', 1257 1254 'javelin-vector', 1258 1255 'javelin-typeahead-static-source', 1256 + ), 1257 + '549459b8' => array( 1258 + 'javelin-behavior', 1259 1259 ), 1260 1260 '54b612ba' => array( 1261 1261 'javelin-color',
+1 -1
webroot/rsrc/js/application/harbormaster/behavior-harbormaster-log.js
··· 16 16 17 17 e.kill(); 18 18 19 - expand(e.getTarget(), true); 19 + expand(e.getNode('harbormaster-log-expand'), true); 20 20 }); 21 21 22 22 function expand(node, is_action) {