recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Include owners packages in the MailableFunction datasource

Summary:
Ref T13151. See PHI684. Currently, the `MailableFunction` datasource does not include Owners packages, but they are valid subscribers and the `Mailable` datasource includes them.

Include them in the `MailableFunction` datasource, too.

Test Plan: Searched for revisions with particular package subscribers, got expected results in the UI (tokenizer knew about packages) and response.

Reviewers: amckinley, jmeador

Reviewed By: jmeador

Maniphest Tasks: T13151

Differential Revision: https://secure.phabricator.com/D19476

epriestley 2951e0c8 7729c51c

+4 -1
+3 -1
src/applications/metamta/typeahead/PhabricatorMetaMTAMailableFunctionDatasource.php
··· 8 8 } 9 9 10 10 public function getPlaceholderText() { 11 - return pht('Type a username, project, mailing list, or function...'); 11 + return pht( 12 + 'Type a username, project, mailing list, package, or function...'); 12 13 } 13 14 14 15 public function getDatasourceApplicationClass() { ··· 21 22 new PhabricatorPeopleDatasource(), 22 23 new PhabricatorProjectMembersDatasource(), 23 24 new PhabricatorProjectDatasource(), 25 + new PhabricatorOwnersPackageDatasource(), 24 26 ); 25 27 } 26 28
+1
src/applications/search/field/PhabricatorSearchSubscribersField.php
··· 10 10 protected function getValueFromRequest(AphrontRequest $request, $key) { 11 11 $allow_types = array( 12 12 PhabricatorProjectProjectPHIDType::TYPECONST, 13 + PhabricatorOwnersPackagePHIDType::TYPECONST, 13 14 ); 14 15 return $this->getUsersFromRequest($request, $key, $allow_types); 15 16 }