@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Don't raise a policy exception if a user can't see the parent revision of a new diff
Summary: Ref T603. We currently bomb out here, but should just continue forward. I'm fairly certain we don't even use this for anything anymore (it has been replaced by "depends on") but need to check that.
Test Plan: Created a new revision with `arc diff`.
Reviewers: ljalonen, btrahan, #blessed_reviewers, chad
Reviewed By: chad
CC: aran
Maniphest Tasks: T603
Differential Revision: https://secure.phabricator.com/D7255
+5
-1
+5
-1
src/applications/differential/conduit/ConduitAPI_differential_creatediff_Method.php
+5
-1
src/applications/differential/conduit/ConduitAPI_differential_creatediff_Method.php
···
59
59
60
60
$parent_id = $request->getValue('parentRevisionID');
61
61
if ($parent_id) {
62
+
// NOTE: If the viewer can't see the parent revision, just don't set
63
+
// a parent revision ID. This isn't used for anything meaningful.
64
+
// TODO: Can we delete this entirely?
62
65
$parent_rev = id(new DifferentialRevisionQuery())
63
66
->setViewer($request->getUser())
64
67
->withIDs(array($parent_id))
65
-
->executeOne();
68
+
->execute();
66
69
if ($parent_rev) {
70
+
$parent_rev = head($parent_rev);
67
71
if ($parent_rev->getStatus() !=
68
72
ArcanistDifferentialRevisionStatus::CLOSED) {
69
73
$diff->setParentRevisionID($parent_id);