@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Icons: Harmonize FontAwesome name aliases across codebase

Summary:
Do not use several FontAwesome aliases for the very same font icon but consistently use only one of them.
This may make resolving T16035 a tiny bit easier some day.

* fa-bar-chart-o -> fa-bar-chart
* fa-dashboard -> fa-tachometer
* fa-file-sound-o -> fa-file-audio-o
* fa-file-zip-o -> fa-file-archive-o
* fa-bank -> fa-university
* fa-institution -> fa-university
* fa-image -> fa-picture-o
* fa-photo -> fa-picture-o
* fa-paste -> fa-clipboard
* fa-send-o -> fa-paperplane-o
* fa-toggle-down -> fa-caret-square-o-down

This is not a breaking change for third-parties as the aliases still remain in `webroot/rsrc/css/font/font-awesome.css`.

Closes T16251

Test Plan: Repeatedly grep the codebase for font icons and their several CSS class names defined in `webroot/rsrc/css/font/font-awesome.css`

Reviewers: O1 Blessed Committers, mainframe98

Reviewed By: O1 Blessed Committers, mainframe98

Subscribers: mainframe98, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T16251

Differential Revision: https://we.phorge.it/D26304

+23 -27
+1 -1
resources/sql/autopatches/20161212.dashboards.01.icon.sql
··· 2 2 ADD icon VARCHAR(32) NOT NULL; 3 3 4 4 UPDATE {$NAMESPACE}_dashboard.dashboard 5 - SET icon = 'fa-dashboard'; 5 + SET icon = 'fa-tachometer';
+1 -1
src/applications/calendar/icon/PhabricatorCalendarIconSet.php
··· 27 27 'fa-cutlery' => pht('Meal'), 28 28 29 29 'fa-paw' => pht('Pet Activity'), 30 - 'fa-institution' => pht('Official Business'), 30 + 'fa-university' => pht('Official Business'), 31 31 'fa-bus' => pht('Field Trip'), 32 32 'fa-microphone' => pht('Conference'), 33 33 );
+1 -1
src/applications/conpherence/view/ConpherenceDurableColumnView.php
··· 297 297 298 298 $minimize = id(new PHUIListItemView()) 299 299 ->setName(pht('Minimize Window')) 300 - ->setIcon('fa-toggle-down') 300 + ->setIcon('fa-caret-square-o-down') 301 301 ->addClass('core-menu-item') 302 302 ->addClass('conpherence-minimize-icon') 303 303 ->addSigil('conpherence-minimize-window')
+1 -1
src/applications/dashboard/application/PhabricatorDashboardApplication.php
··· 19 19 } 20 20 21 21 public function getIcon() { 22 - return 'fa-dashboard'; 22 + return 'fa-tachometer'; 23 23 } 24 24 25 25 public function isPinnedByDefault(PhabricatorUser $viewer) {
+1 -1
src/applications/dashboard/controller/PhabricatorDashboardConsoleController.php
··· 29 29 $menu->addItem( 30 30 id(new PHUIObjectItemView()) 31 31 ->setHeader(pht('Dashboards')) 32 - ->setImageIcon('fa-dashboard') 32 + ->setImageIcon('fa-tachometer') 33 33 ->setHref($this->getApplicationURI('/')) 34 34 ->setClickable(true) 35 35 ->addAttribute(
+1 -1
src/applications/dashboard/icon/PhabricatorDashboardIconSet.php
··· 12 12 protected function newIcons() { 13 13 $map = array( 14 14 'fa-home' => pht('Home'), 15 - 'fa-dashboard' => pht('Dashboard'), 15 + 'fa-tachometer' => pht('Dashboard'), 16 16 'fa-th-large' => pht('Blocks'), 17 17 'fa-columns' => pht('Columns'), 18 18 'fa-bookmark' => pht('Page Saver'),
+1 -1
src/applications/dashboard/storage/PhabricatorDashboard.php
··· 30 30 public static function initializeNewDashboard(PhabricatorUser $actor) { 31 31 return id(new PhabricatorDashboard()) 32 32 ->setName('') 33 - ->setIcon('fa-dashboard') 33 + ->setIcon('fa-tachometer') 34 34 ->setViewPolicy(PhabricatorPolicies::getMostOpenPolicy()) 35 35 ->setEditPolicy($actor->getPHID()) 36 36 ->setStatus(self::STATUS_ACTIVE)
+1 -1
src/applications/files/config/PhabricatorFilesConfigOptions.php
··· 111 111 // pdf file icon 112 112 'application/pdf' => 'fa-file-pdf-o', 113 113 // zip file icon 114 - 'application/zip' => 'fa-file-zip-o', 114 + 'application/zip' => 'fa-file-archive-o', 115 115 // msword icon 116 116 'application/msword' => 'fa-file-word-o', 117 117 // msexcel
+1 -1
src/applications/files/constants/FileTypeIcon.php
··· 16 16 case 'wav': 17 17 case 'mp3': 18 18 case 'aiff': 19 - $icon = 'fa-file-sound-o'; 19 + $icon = 'fa-file-audio-o'; 20 20 break; 21 21 case 'm4v': 22 22 case 'mov':
+1 -1
src/applications/files/document/PhabricatorAudioDocumentEngine.php
··· 10 10 } 11 11 12 12 protected function getDocumentIconIcon(PhabricatorDocumentRef $ref) { 13 - return 'fa-file-sound-o'; 13 + return 'fa-file-audio-o'; 14 14 } 15 15 16 16 protected function getByteLengthLimit() {
+1 -1
src/applications/fund/controller/FundInitiativeViewController.php
··· 159 159 $curtain->addAction( 160 160 id(new PhabricatorActionView()) 161 161 ->setName(pht('View Backers')) 162 - ->setIcon('fa-bank') 162 + ->setIcon('fa-university') 163 163 ->setHref($this->getApplicationURI("/backers/{$id}/"))); 164 164 165 165 return $curtain;
+1 -1
src/applications/fund/xaction/FundInitiativeMerchantTransaction.php
··· 86 86 } 87 87 88 88 public function getIcon() { 89 - return 'fa-bank'; 89 + return 'fa-university'; 90 90 } 91 91 92 92
+1 -1
src/applications/maniphest/xaction/ManiphestTaskCoverImageTransaction.php
··· 134 134 } 135 135 136 136 public function getIcon() { 137 - return 'fa-image'; 137 + return 'fa-picture-o'; 138 138 } 139 139 140 140
+1 -1
src/applications/packages/controller/PhabricatorPackagesConsoleController.php
··· 18 18 id(new PHUIObjectItemView()) 19 19 ->setHeader(pht('Publishers')) 20 20 ->setHref($this->getApplicationURI('publisher/')) 21 - ->setImageIcon('fa-institution') 21 + ->setImageIcon('fa-university') 22 22 ->setClickable(true) 23 23 ->addAttribute( 24 24 pht(
+1 -1
src/applications/paste/application/PhabricatorPasteApplication.php
··· 11 11 } 12 12 13 13 public function getIcon() { 14 - return 'fa-paste'; 14 + return 'fa-clipboard'; 15 15 } 16 16 17 17 public function getTitleGlyph() {
+1 -1
src/applications/people/icon/PhabricatorPeopleIconSet.php
··· 121 121 ), 122 122 array( 123 123 'key' => 'analysis', 124 - 'icon' => 'fa-bar-chart-o', 124 + 'icon' => 'fa-bar-chart', 125 125 'name' => pht('Analysis'), 126 126 ), 127 127 array(
+1 -1
src/applications/project/menuitem/PhabricatorProjectPictureProfileMenuItem.php
··· 14 14 } 15 15 16 16 public function getMenuItemTypeIcon() { 17 - return 'fa-image'; 17 + return 'fa-picture-o'; 18 18 } 19 19 20 20 public function canHideMenuItem(
+1 -1
src/applications/project/xaction/PhabricatorProjectImageTransaction.php
··· 63 63 } 64 64 65 65 public function getIcon() { 66 - return 'fa-photo'; 66 + return 'fa-picture-o'; 67 67 } 68 68 69 69 public function extractFilePHIDs($object, $value) {
+1 -1
src/applications/search/controller/PhabricatorApplicationSearchController.php
··· 921 921 922 922 if ($can_use && $is_installed) { 923 923 $actions[] = id(new PhabricatorActionView()) 924 - ->setIcon('fa-dashboard') 924 + ->setIcon('fa-tachometer') 925 925 ->setName(pht('Add to Dashboard')) 926 926 ->setWorkflow(true) 927 927 ->setHref("/dashboard/panel/install/{$engine_class}/{$query_key}/");
+1 -1
src/applications/search/menuitem/PhabricatorDashboardProfileMenuItem.php
··· 11 11 private $dashboardHandle; 12 12 13 13 public function getMenuItemTypeIcon() { 14 - return 'fa-dashboard'; 14 + return 'fa-tachometer'; 15 15 } 16 16 17 17 public function getMenuItemTypeName() {
+1 -1
src/applications/settings/panel/PhabricatorNotificationsSettingsPanel.php
··· 159 159 160 160 $button = id(new PHUIButtonView()) 161 161 ->setTag('a') 162 - ->setIcon('fa-send-o') 162 + ->setIcon('fa-paper-plane-o') 163 163 ->setWorkflow(true) 164 164 ->setText(pht('Send Test Notification')) 165 165 ->setHref('/notification/test/')
+2 -6
src/view/phui/PHUIIconView.php
··· 279 279 'fa-folder-open', 280 280 'fa-arrows-v', 281 281 'fa-arrows-h', 282 - 'fa-bar-chart-o', 282 + 'fa-bar-chart', 283 283 'fa-twitter-square', 284 284 'fa-facebook-square', 285 285 'fa-camera-retro', ··· 533 533 'fa-envelope-square', 534 534 'fa-wordpress', 535 535 'fa-openid', 536 - 'fa-institution', 537 - 'fa-bank', 538 536 'fa-university', 539 537 'fa-mortar-board', 540 538 'fa-graduation-cap', ··· 580 578 'fa-file-photo-o', 581 579 'fa-file-picture-o', 582 580 'fa-file-image-o', 583 - 'fa-file-zip-o', 584 581 'fa-file-archive-o', 585 - 'fa-file-sound-o', 582 + 'fa-file-audio-o', 586 583 'fa-file-movie-o', 587 584 'fa-file-code-o', 588 585 'fa-vine', ··· 601 598 'fa-wechat', 602 599 'fa-send', 603 600 'fa-paper-plane', 604 - 'fa-send-o', 605 601 'fa-paper-plane-o', 606 602 'fa-history', 607 603 'fa-circle-thin',