@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Update project manage page for two column
Summary: Fixes T10545. Converts layout to two column.
Test Plan: Review a few project manage pages, see new layout and flag ability.
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Maniphest Tasks: T10545
Differential Revision: https://secure.phabricator.com/D15450
+26
-28
+26
-27
src/applications/project/controller/PhabricatorProjectManageController.php
+26
-27
src/applications/project/controller/PhabricatorProjectManageController.php
···
30
30
$header->setStatus('fa-ban', 'red', pht('Archived'));
31
31
}
32
32
33
-
$actions = $this->buildActionListView($project);
34
-
$properties = $this->buildPropertyListView($project, $actions);
35
-
36
-
$object_box = id(new PHUIObjectBoxView())
37
-
->setHeader($header)
38
-
->addPropertyList($properties);
33
+
$curtain = $this->buildCurtain($project);
34
+
$properties = $this->buildPropertyListView($project);
39
35
40
36
$timeline = $this->buildTransactionTimeline(
41
37
$project,
···
47
43
48
44
$crumbs = $this->buildApplicationCrumbs();
49
45
$crumbs->addTextCrumb(pht('Manage'));
46
+
$crumbs->setBorder(true);
47
+
48
+
$manage = id(new PHUITwoColumnView())
49
+
->setHeader($header)
50
+
->setCurtain($curtain)
51
+
->addPropertySection(pht('DETAILS'), $properties)
52
+
->setMainColumn(
53
+
array(
54
+
$timeline,
55
+
));
50
56
51
57
return $this->newPage()
52
58
->setNavigation($nav)
···
58
64
))
59
65
->appendChild(
60
66
array(
61
-
$object_box,
62
-
$timeline,
67
+
$manage,
63
68
));
64
69
}
65
70
66
-
private function buildActionListView(PhabricatorProject $project) {
67
-
$request = $this->getRequest();
68
-
$viewer = $request->getUser();
71
+
private function buildCurtain(PhabricatorProject $project) {
72
+
$viewer = $this->getViewer();
69
73
70
74
$id = $project->getID();
71
-
72
-
$view = id(new PhabricatorActionListView())
73
-
->setUser($viewer);
74
-
75
75
$can_edit = PhabricatorPolicyFilter::hasCapability(
76
76
$viewer,
77
77
$project,
78
78
PhabricatorPolicyCapability::CAN_EDIT);
79
79
80
-
$view->addAction(
80
+
$curtain = $this->newCurtainView($project);
81
+
82
+
$curtain->addAction(
81
83
id(new PhabricatorActionView())
82
84
->setName(pht('Edit Details'))
83
85
->setIcon('fa-pencil')
···
85
87
->setDisabled(!$can_edit)
86
88
->setWorkflow(!$can_edit));
87
89
88
-
$view->addAction(
90
+
$curtain->addAction(
89
91
id(new PhabricatorActionView())
90
92
->setName(pht('Edit Menu'))
91
93
->setIcon('fa-th-list')
···
93
95
->setDisabled(!$can_edit)
94
96
->setWorkflow(!$can_edit));
95
97
96
-
$view->addAction(
98
+
$curtain->addAction(
97
99
id(new PhabricatorActionView())
98
100
->setName(pht('Edit Picture'))
99
101
->setIcon('fa-picture-o')
···
102
104
->setWorkflow(!$can_edit));
103
105
104
106
if ($project->isArchived()) {
105
-
$view->addAction(
107
+
$curtain->addAction(
106
108
id(new PhabricatorActionView())
107
109
->setName(pht('Activate Project'))
108
110
->setIcon('fa-check')
···
110
112
->setDisabled(!$can_edit)
111
113
->setWorkflow(true));
112
114
} else {
113
-
$view->addAction(
115
+
$curtain->addAction(
114
116
id(new PhabricatorActionView())
115
117
->setName(pht('Archive Project'))
116
118
->setIcon('fa-ban')
···
119
121
->setWorkflow(true));
120
122
}
121
123
122
-
return $view;
124
+
return $curtain;
123
125
}
124
126
125
127
private function buildPropertyListView(
126
-
PhabricatorProject $project,
127
-
PhabricatorActionListView $actions) {
128
-
$request = $this->getRequest();
129
-
$viewer = $request->getUser();
128
+
PhabricatorProject $project) {
129
+
$viewer = $this->getViewer();
130
130
131
131
$view = id(new PHUIPropertyListView())
132
-
->setUser($viewer)
133
-
->setActionList($actions);
132
+
->setUser($viewer);
134
133
135
134
$view->addProperty(
136
135
pht('Looks Like'),