@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Update DarkConsole for handleRequest
Summary: Ref T8628
Test Plan: Updated DarkConsoleDataController and observed that the darkconsole still works as expected
Reviewers: epriestley, #blessed_reviewers
Reviewed By: epriestley, #blessed_reviewers
Subscribers: Korvin, epriestley, yelirekim
Maniphest Tasks: T8628
Differential Revision: https://secure.phabricator.com/D16570
+5
-11
+5
-11
src/applications/console/controller/DarkConsoleDataController.php
+5
-11
src/applications/console/controller/DarkConsoleDataController.php
···
2
2
3
3
final class DarkConsoleDataController extends PhabricatorController {
4
4
5
-
private $key;
6
-
7
5
public function shouldRequireLogin() {
8
6
return !PhabricatorEnv::getEnvConfig('darkconsole.always-on');
9
7
}
···
16
14
return true;
17
15
}
18
16
19
-
public function willProcessRequest(array $data) {
20
-
$this->key = $data['key'];
21
-
}
22
-
23
-
public function processRequest() {
24
-
$request = $this->getRequest();
25
-
$user = $request->getUser();
17
+
public function handleRequest(AphrontRequest $request) {
18
+
$viewer = $request->getViewer();
19
+
$key = $request->getURIData('key');
26
20
27
21
$cache = new PhabricatorKeyValueDatabaseCache();
28
22
$cache = new PhutilKeyValueCacheProfiler($cache);
29
23
$cache->setProfiler(PhutilServiceProfiler::getInstance());
30
24
31
-
$result = $cache->getKey('darkconsole:'.$this->key);
25
+
$result = $cache->getKey('darkconsole:'.$key);
32
26
if (!$result) {
33
27
return new Aphront400Response();
34
28
}
···
43
37
return new Aphront400Response();
44
38
}
45
39
46
-
if ($result['user'] != $user->getPHID()) {
40
+
if ($result['user'] != $viewer->getPHID()) {
47
41
return new Aphront400Response();
48
42
}
49
43