@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Move timeline anchor targets up to evade a Chrome 55 behavioral change
Summary: Fixes T11997. This lifts the targets out of the containing `overflow: hidden;` div so Chrome is willing to target them.
Test Plan: In Chrome, visited direct comment links and ended up in the right place. Clicked comment anchors, saw browser jump around again.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T11997
Differential Revision: https://secure.phabricator.com/D17033
+12
-6
+12
-6
src/view/phui/PHUITimelineEventView.php
+12
-6
src/view/phui/PHUITimelineEventView.php
···
347
347
$group_children = array();
348
348
foreach ($events as $event) {
349
349
if ($event->shouldRenderEventTitle()) {
350
+
351
+
// Render the group anchor here, outside the title box. If we render
352
+
// it inside the title box it ends up completely hidden and Chrome 55
353
+
// refuses to jump to it. See T11997 for discussion.
354
+
355
+
if ($extra && $this->anchor) {
356
+
$group_titles[] = id(new PhabricatorAnchorView())
357
+
->setAnchorName($this->anchor)
358
+
->render();
359
+
}
360
+
350
361
$group_titles[] = $event->renderEventTitle(
351
362
$force_icon,
352
363
$has_menu,
···
533
544
Javelin::initBehavior('phabricator-watch-anchor');
534
545
Javelin::initBehavior('phabricator-tooltips');
535
546
536
-
$anchor = id(new PhabricatorAnchorView())
537
-
->setAnchorName($this->anchor)
538
-
->render();
539
-
540
547
$date = array(
541
-
$anchor,
542
548
javelin_tag(
543
549
'a',
544
550
array(
···
546
552
'sigil' => 'has-tooltip',
547
553
'meta' => array(
548
554
'tip' => $content_source,
549
-
),
555
+
),
550
556
),
551
557
$date),
552
558
);