@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Ignore post-write repository synchronization if no devices are configured
Summary: Fixes T10789. If we aren't configured with a device, we never grabbed a lock in the first place, and should not expect one to be held.
Test Plan: Pushed non-cluster-configured Git SSH repository.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T10789
Differential Revision: https://secure.phabricator.com/D15692
+5
-8
+5
-8
src/applications/repository/storage/PhabricatorRepository.php
+5
-8
src/applications/repository/storage/PhabricatorRepository.php
···
2375
2375
* @task sync
2376
2376
*/
2377
2377
public function synchronizeWorkingCopyAfterWrite() {
2378
+
$device = AlmanacKeys::getLiveDevice();
2379
+
if (!$device) {
2380
+
return;
2381
+
}
2382
+
2378
2383
if (!$this->clusterWriteLock) {
2379
2384
throw new Exception(
2380
2385
pht(
2381
2386
'Trying to synchronize after write, but not holding a write '.
2382
2387
'lock!'));
2383
-
}
2384
-
2385
-
$device = AlmanacKeys::getLiveDevice();
2386
-
if (!$device) {
2387
-
throw new Exception(
2388
-
pht(
2389
-
'Trying to synchronize after write, but this host is not an '.
2390
-
'Almanac device.'));
2391
2388
}
2392
2389
2393
2390
$repository_phid = $this->getPHID();