@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix check in PhabricatorMySQLSetupCheck:shouldUseMySQLSearchEngine()
Summary:
Per PHPStan static code analysis, currently
`Instanceof between PhabricatorSearchService and PhabricatorMySQLSearchHost will always evaluate to false`.
Per discussion in the task and per testing, make the check work.
Closes T15891
Test Plan: Probably set up a Phorge instance with recent MariaDB/MySQL, and set up a Phorge instance with ancient DB versions (MySQL 5.6.3 or older; MariaDB 10.0 or older) not supporting FULLTEXT indexes for InnoDB tables?
Reviewers: O1 Blessed Committers, 20after4
Reviewed By: O1 Blessed Committers, 20after4
Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno
Maniphest Tasks: T15891
Differential Revision: https://we.phorge.it/D25975
+2
-1
+2
-1
src/applications/config/check/PhabricatorMySQLSetupCheck.php
+2
-1
src/applications/config/check/PhabricatorMySQLSetupCheck.php
···
375
375
protected function shouldUseMySQLSearchEngine() {
376
376
$services = PhabricatorSearchService::getAllServices();
377
377
foreach ($services as $service) {
378
-
if ($service instanceof PhabricatorMySQLSearchHost) {
378
+
if ($service->getEngine() instanceof
379
+
PhabricatorFerretFulltextStorageEngine) {
379
380
return true;
380
381
}
381
382
}