@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix a warning in PhabricatorRepositoryCommit using an unary operation
Summary:
Avoid a static code analysis warning
`Unary operation "~" on mixed results in an error.`
by explicit casting $flag to an integer (which it should be anyways) before applying the bitwise operator.
Test Plan: Run static code analysis, get one complaint less.
Reviewers: O1 Blessed Committers, mainframe98
Reviewed By: O1 Blessed Committers, mainframe98
Subscribers: mainframe98, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno
Differential Revision: https://we.phorge.it/D26312
+1
-1
+1
-1
src/applications/repository/storage/PhabricatorRepositoryCommit.php
+1
-1
src/applications/repository/storage/PhabricatorRepositoryCommit.php
···
81
81
return $this->adjustImportStatusFlag($flag, false);
82
82
}
83
83
84
-
private function adjustImportStatusFlag($flag, $set) {
84
+
private function adjustImportStatusFlag(int $flag, $set) {
85
85
$conn_w = $this->establishConnection('w');
86
86
$table_name = $this->getTableName();
87
87
$id = $this->getID();