@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Clean up Maniphest Batch Editor UI
Summary: Finishes up work on PHUIInsetForm, cleans up the UI a bit when editing multiple tasks
Test Plan:
Edit multiple tasks, apply some new projects, still works as expected.
{F236044}
Reviewers: btrahan, epriestley
Reviewed By: epriestley
Subscribers: Korvin, epriestley
Differential Revision: https://secure.phabricator.com/D10881
+8
-10
+7
-6
src/applications/maniphest/controller/ManiphestBatchEditController.php
+7
-6
src/applications/maniphest/controller/ManiphestBatchEditController.php
···
115
115
'id' => 'batch-form-actions',
116
116
)));
117
117
$form->appendChild(
118
-
phutil_tag('p', array(), pht('These tasks will be edited:')));
119
-
$form->appendChild($list);
120
-
$form->appendChild(
121
118
id(new PHUIFormInsetView())
122
-
->setTitle('Actions')
119
+
->setTitle(pht('Actions'))
123
120
->setRightButton(javelin_tag(
124
121
'a',
125
122
array(
···
146
143
$crumbs = $this->buildApplicationCrumbs();
147
144
$crumbs->addTextCrumb($title);
148
145
146
+
$task_box = id(new PHUIObjectBoxView())
147
+
->setHeaderText(pht('Selected Tasks'))
148
+
->appendChild($list);
149
+
149
150
$form_box = id(new PHUIObjectBoxView())
150
-
->setHeaderText(pht('Batch Edit Tasks'))
151
+
->setHeaderText(pht('Batch Editor'))
151
152
->setForm($form);
152
153
153
154
return $this->buildApplicationPage(
154
155
array(
155
156
$crumbs,
157
+
$task_box,
156
158
$form_box,
157
159
),
158
160
array(
159
161
'title' => $title,
160
-
'device' => false,
161
162
));
162
163
}
163
164
+1
-4
src/view/form/PHUIFormInsetView.php
+1
-4
src/view/form/PHUIFormInsetView.php
···
69
69
'style' => 'float: right;',
70
70
),
71
71
$this->rightButton);
72
+
$right_button = phutil_tag_div('grouped', $right_button);
72
73
}
73
74
74
75
if ($this->description) {
···
76
77
'p',
77
78
array(),
78
79
$this->description);
79
-
80
-
if ($right_button) {
81
-
$desc = hsprintf('%s<div style="clear: both;"></div>', $desc);
82
-
}
83
80
}
84
81
85
82
$div_attributes = $this->divAttributes;