recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Don't notify without notifiable attendees

Summary: Events with no attendees (e.g. fresh instances of recurring events) would trigger an exception when sending notifications, because `$attendee_map` would still get populated.

Test Plan: Declined event, restarted daemons. Did not see exception. Accepted event, restarted daemons. Saw "[Calendar] [Reminder]" email.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D18835

authored by

Dmitri Iouchtchenko and committed by
epriestley 39382465 e411d759

+3 -2
+3 -2
src/applications/calendar/notifications/PhabricatorCalendarNotificationEngine.php
··· 100 100 } 101 101 $notifiable_phids[] = $invitee->getInviteePHID(); 102 102 } 103 - if (!$notifiable_phids) { 103 + if ($notifiable_phids) { 104 + $attendee_map[$key] = array_fuse($notifiable_phids); 105 + } else { 104 106 unset($events[$key]); 105 107 } 106 - $attendee_map[$key] = array_fuse($notifiable_phids); 107 108 } 108 109 if (!$attendee_map) { 109 110 // None of the events have any notifiable attendees, so there is no